Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: angular/angular.js
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: c06c5a3
Choose a base ref
...
head repository: angular/angular.js
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 15ec78f
Choose a head ref
  • 4 commits
  • 4 files changed
  • 1 contributor

Commits on Mar 30, 2011

  1. call $eval in repeater only when needed 

    when growing children linker calls eval for new nodes, so we need
to call it only for reused nodes.
    @IgorMinar
    IgorMinar committed Mar 30, 2011
    Configuration menu
    Copy the full SHA
    89c25fe View commit details
    Browse the repository at this point in the history

  2. extend size() to take ownPropsOnly param 

    - extend size() to take size(obj, ownPropsOnly)
- add specs for size()
- update docs to mention string support
- use size() in ng:repeat

including the hasOwnProp check for all object doesn't create
significant perf penalty:
http://jsperf.com/dedicated-code-branch-for-hasownprop
    @IgorMinar
    IgorMinar committed Mar 30, 2011
    Configuration menu
    Copy the full SHA
    96a1df1 View commit details
    Browse the repository at this point in the history

  3. correct size() impl for object's w/ 'length' prop 

    the original implementation returned incorrect value value for
objects with 'length' property.
    @IgorMinar
    IgorMinar committed Mar 30, 2011
    Configuration menu
    Copy the full SHA
    a4863d5 View commit details
    Browse the repository at this point in the history

  4. use document fragments to grow repeaters 

    - unless we are repeating OPTION elements, buffer new nodes in document
  fragment and append them to the DOM in one go at the end
- for OPTION elements we have to keep on using the old way
  because of how option widget communicates with select widget
  this should be change, but that change is out of scope of this CL
- modify jqLite to support wrapping of document fragments
- fix jqLite documentation typo

This change unintentionally avoids the following webkit bug that
that affects repeater growth:
https://bugs.webkit.org/show_bug.cgi?id=57059

However the following bug affecting shrining of repeaters is still
unresolved https://bugs.webkit.org/show_bug.cgi?id=57061
    @IgorMinar
    IgorMinar committed Mar 30, 2011
    Configuration menu
    Copy the full SHA
    15ec78f View commit details
    Browse the repository at this point in the history
Loading