From f953b8fe9b68660cd434cc9c1ecf2cd51b497908 Mon Sep 17 00:00:00 2001 From: Katja Marttila Date: Fri, 6 Jun 2025 09:02:17 +0300 Subject: Fix the 'recommended size exceeded' message The message was shown when the space was freed, as we were comparing unsigned and signed integers. Change-Id: I97a759d01e663837421515661e4a102d5683ee83 Reviewed-by: Arttu Tarkiainen --- src/libs/installer/packagemanagercore.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src') diff --git a/src/libs/installer/packagemanagercore.cpp b/src/libs/installer/packagemanagercore.cpp index cf24575ae..020c897cb 100644 --- a/src/libs/installer/packagemanagercore.cpp +++ b/src/libs/installer/packagemanagercore.cpp @@ -3432,7 +3432,7 @@ bool PackageManagerCore::checkAvailableSpace() qDebug().nospace() << "Cannot determine available space on device. " "Volume descriptor: " << targetVolume.volumeDescriptor() << ", Mount path: " << targetVolume.mountPath() << ". Continue silently."; - if (required < scRecommendedMaxSize) + if (required < 0 || required < scRecommendedMaxSize) emit availableSpaceChanged(SpaceInfo::SpaceAvailable); else emit availableSpaceChanged(SpaceInfo::RecommendedSizeExceeded); @@ -3502,7 +3502,7 @@ bool PackageManagerCore::checkAvailableSpace() : tr("Installation will use %1 of disk space.")) .arg(humanReadableSize(requiredDiskSpace()))).simplified(); - if (required < scRecommendedMaxSize) + if (required < 0 || required < scRecommendedMaxSize) emit availableSpaceChanged(SpaceInfo::SpaceAvailable); else emit availableSpaceChanged(SpaceInfo::RecommendedSizeExceeded); -- cgit v1.2.3