aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorNikunj Arora <[email protected]>2025-06-27 11:59:58 +0300
committerAssam Boudjelthia <[email protected]>2025-06-27 12:59:37 +0000
commit50639f89405690fcb67c08bff7149be64ac7526d (patch)
tree7417e13f853bbf1020d99f6286d028fa2c79e2b8
parent003fd96b740dfb9acc77fb61ad27b577260c8634 (diff)
Add a check that the provided ninja path is a fileHEADdev
Avoid false positive on a directory named ninja on unix systems. Fixes: QTTA-402 Pick-to: 4.1 Change-Id: Ib269c544fa7bacb49cbfa767a08d6b6570c4f577 Reviewed-by: Olli Vuolteenaho <[email protected]> Reviewed-by: Assam Boudjelthia <[email protected]>
-rw-r--r--src/main/java/org/qtproject/qt/androidstudiotools/QtSettingPanel.java3
1 files changed, 2 insertions, 1 deletions
diff --git a/src/main/java/org/qtproject/qt/androidstudiotools/QtSettingPanel.java b/src/main/java/org/qtproject/qt/androidstudiotools/QtSettingPanel.java
index e152177..8cda7bf 100644
--- a/src/main/java/org/qtproject/qt/androidstudiotools/QtSettingPanel.java
+++ b/src/main/java/org/qtproject/qt/androidstudiotools/QtSettingPanel.java
@@ -130,7 +130,8 @@ class QtSettingPanel {
if (SystemUtils.IS_OS_WINDOWS)
ninjaBinName += ".exe";
- boolean checkNinja = new File(ninjaLocation, ninjaBinName).exists();
+ File ninjaFile = new File(ninjaLocation, ninjaBinName);
+ boolean checkNinja = ninjaFile.exists() && ninjaFile.isFile();
if (ninjaLocation.isBlank() || !checkNinja) {
String errorMsg = "No ninja executable found under the provided ninja path";
return new ValidationInfo(errorMsg, m_ninjaPathLocationBtn.getTextField());