summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMarc Mutz <[email protected]>2025-04-23 10:35:19 +0200
committerMarc Mutz <[email protected]>2025-06-03 17:13:55 +0000
commitc485c07c6d7e29eae5e633adb9429e293f63b63b (patch)
tree2c4dcd2322d45841381c79d66d1f1839c4be95e1
parentae973dc2de5ce3b5a7d18018691479013d91053d (diff)
Explain what "junk" means in tst_QDataStream::status_QBitArray_data()HEADdev
It means the data contains bits outside the [0, size()[ range. Found while debugging why these data rows fail in the 5.15 cherry-pick of 78f8dfc5427457783ceef7d85885cddbec035ebe. Amends the start of the public history. Pick-to: 6.10 6.9 6.8 6.5 5.15 Change-Id: Ic21d15da25944d4897357dd27e2986d448b5ee60 Reviewed-by: Ivan Solovev <[email protected]>
-rw-r--r--tests/auto/corelib/serialization/qdatastream/tst_qdatastream.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/tests/auto/corelib/serialization/qdatastream/tst_qdatastream.cpp b/tests/auto/corelib/serialization/qdatastream/tst_qdatastream.cpp
index c8fb5f25f70..37cc4252247 100644
--- a/tests/auto/corelib/serialization/qdatastream/tst_qdatastream.cpp
+++ b/tests/auto/corelib/serialization/qdatastream/tst_qdatastream.cpp
@@ -3029,7 +3029,7 @@ void tst_QDataStream::status_QBitArray_data()
QTest::newRow("new badsize 9") << QDataStream::Qt_6_0 << QByteArray("\x00\x00\x00\x00\x00\x00\x00\x09\xff", 9) << (int) QDataStream::ReadPastEnd << QBitArray();
QTest::newRow("new badsize 0x10000") << QDataStream::Qt_6_0 << QByteArray("\x00\x00\x00\x01\x00\x00\x00\x00\x00", 9) << (int) QDataStream::ReadPastEnd << QBitArray();
- // corrupt data
+ // corrupt data: bits in positions outsize [0, size()[
QTest::newRow("junk 1a") << QDataStream::Qt_5_15 << QByteArray("\x00\x00\x00\x01\x02", 5) << (int) QDataStream::ReadCorruptData << QBitArray();
QTest::newRow("junk 1b") << QDataStream::Qt_5_15 << QByteArray("\x00\x00\x00\x01\x04", 5) << (int) QDataStream::ReadCorruptData << QBitArray();
QTest::newRow("junk 1c") << QDataStream::Qt_5_15 << QByteArray("\x00\x00\x00\x01\x08", 5) << (int) QDataStream::ReadCorruptData << QBitArray();