// Copyright (C) 2021 The Qt Company Ltd. // SPDX-License-Identifier: LicenseRef-Qt-Commercial OR GPL-3.0-only #include #include #include #include #include #include #include #include #include #include "testmodel.h" #include #include #include using namespace QQuickViewTestUtils; using namespace QQuickVisualTestUtils; #define LOAD_TREEVIEW(fileName) \ view->setSource(testFileUrl(fileName)); \ view->show(); \ QVERIFY(QTest::qWaitForWindowActive(view.get())); \ auto treeView = view->rootObject()->property("treeView").value(); \ QVERIFY(treeView); \ auto treeViewPrivate = QQuickTreeViewPrivate::get(treeView); \ Q_UNUSED(treeViewPrivate) \ auto model = treeView->model().value(); \ Q_UNUSED(model) #define WAIT_UNTIL_POLISHED_ARG(item) \ QVERIFY(QQuickTest::qWaitForPolish(item)) #define WAIT_UNTIL_POLISHED WAIT_UNTIL_POLISHED_ARG(treeView) // ######################################################## class tst_qquicktreeviewdelegate : public QQmlDataTest { Q_OBJECT public: tst_qquicktreeviewdelegate(); private: std::unique_ptr view = nullptr; private slots: void initTestCase() override; void showTreeView(); void expandAndCollapsUsingDoubleClick(); void expandAndCollapseClickOnIndicator_data(); void expandAndCollapseClickOnIndicator(); void pointerNavigationDisabled(); void checkPropertiesRoot(); void checkPropertiesChildren(); void checkCurrentIndex(); void checkClickedSignal_data(); void checkClickedSignal(); void clearSelectionOnClick(); void dragToSelect(); void pressAndHoldToSelect(); }; tst_qquicktreeviewdelegate::tst_qquicktreeviewdelegate() : QQmlDataTest(QT_QMLTEST_DATADIR) { } void tst_qquicktreeviewdelegate::initTestCase() { QQmlDataTest::initTestCase(); qmlRegisterType("TestModel", 1, 0, "TestModel"); view.reset(createView()); } void tst_qquicktreeviewdelegate::showTreeView() { LOAD_TREEVIEW("unmodified.qml"); // Check that the view is showing the root of the tree QCOMPARE(treeViewPrivate->loadedRows.count(), 1); } void tst_qquicktreeviewdelegate::expandAndCollapsUsingDoubleClick() { LOAD_TREEVIEW("unmodified.qml"); // Check that the view only has one row loaded so far (the root of the tree) QCOMPARE(treeViewPrivate->loadedRows.count(), 1); // Expand the root by double clicking on the row const auto item = treeView->itemAtIndex(treeView->index(0, 0)); QVERIFY(item); const QPoint localPos = QPoint(item->width() / 2, item->height() / 2); const QPoint pos = item->window()->contentItem()->mapFromItem(item, localPos).toPoint(); QTest::mouseDClick(item->window(), Qt::LeftButton, Qt::NoModifier, pos); WAIT_UNTIL_POLISHED; // We now expect 5 rows, the root pluss it's 4 children QCOMPARE(treeViewPrivate->loadedRows.count(), 5); // Collapse the root again QTest::mouseDClick(item->window(), Qt::LeftButton, Qt::NoModifier, pos); WAIT_UNTIL_POLISHED; // Check that the view only has one row loaded again (the root of the tree) QCOMPARE(treeViewPrivate->loadedRows.count(), 1); } void tst_qquicktreeviewdelegate::expandAndCollapseClickOnIndicator_data() { QTest::addColumn("interactive"); QTest::newRow("interactive") << true; QTest::newRow("not interactive") << false; } void tst_qquicktreeviewdelegate::expandAndCollapseClickOnIndicator() { QFETCH(bool, interactive); LOAD_TREEVIEW("unmodified.qml"); treeView->setInteractive(interactive); // Check that the view only has one row loaded so far (the root of the tree) QCOMPARE(treeViewPrivate->loadedRows.count(), 1); // Expand the root by clicking on the indicator const auto item = qobject_cast(treeView->itemAtIndex(treeView->index(0, 0))); QVERIFY(item); const auto indicator = item->indicator(); const QPoint localPos = QPoint(indicator->width() / 2, indicator->height() / 2); const QPoint pos = item->window()->contentItem()->mapFromItem(indicator, localPos).toPoint(); QTest::mouseClick(item->window(), Qt::LeftButton, Qt::NoModifier, pos); WAIT_UNTIL_POLISHED; // We now expect 5 rows, the root pluss it's 4 children QCOMPARE(treeViewPrivate->loadedRows.count(), 5); // Collapse the root again QTest::mouseClick(item->window(), Qt::LeftButton, Qt::NoModifier, pos); WAIT_UNTIL_POLISHED; // Check that the view only has one row loaded again (the root of the tree) QCOMPARE(treeViewPrivate->loadedRows.count(), 1); } void tst_qquicktreeviewdelegate::pointerNavigationDisabled() { // Check that treeview respects TableView.pointerNavigationEnabled. // When set to false, TreeView should not handle any pointer navigation events. LOAD_TREEVIEW("unmodified.qml"); treeView->setPointerNavigationEnabled(false); QCOMPARE(treeViewPrivate->loadedRows.count(), 1); QVERIFY(!treeView->isExpanded(0)); // Try to expand the root by clicking on the indicator const auto item = qobject_cast(treeView->itemAtIndex(treeView->index(0, 0))); QVERIFY(item); const auto indicator = item->indicator(); QPoint localPos = QPoint(indicator->width() / 2, indicator->height() / 2); QPoint pos = item->window()->contentItem()->mapFromItem(indicator, localPos).toPoint(); QTest::mouseClick(item->window(), Qt::LeftButton, Qt::NoModifier, pos); // The tree should still be collapsed QVERIFY(!treeView->isExpanded(0)); QVERIFY(!QQuickTest::qIsPolishScheduled(item)); // Try a double click localPos = QPoint(item->width() / 2, item->height() / 2); pos = item->window()->contentItem()->mapFromItem(item, localPos).toPoint(); QTest::mouseDClick(item->window(), Qt::LeftButton, Qt::NoModifier, pos); QVERIFY(!treeView->isExpanded(0)); QVERIFY(!QQuickTest::qIsPolishScheduled(item)); } void tst_qquicktreeviewdelegate::checkPropertiesRoot() { LOAD_TREEVIEW("unmodified.qml"); QCOMPARE(treeViewPrivate->loadedRows.count(), 1); const auto rootFxItem = treeViewPrivate->loadedTableItem(QPoint(0, 0)); QVERIFY(rootFxItem); const auto rootItem = qobject_cast(rootFxItem->item); QVERIFY(rootItem); QCOMPARE(rootItem->treeView(), treeView); QCOMPARE(rootItem->isTreeNode(), true); QCOMPARE(rootItem->expanded(), false); QCOMPARE(rootItem->hasChildren(), true); QCOMPARE(rootItem->depth(), 0); QCOMPARE(rootItem->leftPadding(), rootItem->leftMargin() + (rootItem->depth() * rootItem->indentation()) + rootItem->indicator()->width() + rootItem->spacing()); QCOMPARE(rootItem->indicator()->x(), rootItem->leftMargin() + (rootItem->depth() * rootItem->indentation())); treeView->expand(0); WAIT_UNTIL_POLISHED; QCOMPARE(rootItem->expanded(), true); } void tst_qquicktreeviewdelegate::checkPropertiesChildren() { LOAD_TREEVIEW("unmodified.qml"); treeView->expand(0); WAIT_UNTIL_POLISHED; // We now expect 5 rows, the root pluss it's 4 children QCOMPARE(treeViewPrivate->loadedRows.count(), 5); // The last child has it's own children, so expand that one as well const auto rootIndex = model->index(0, 0); const int childCount = model->rowCount(rootIndex); QCOMPARE(childCount, 4); const auto lastChildIndex = model->index(childCount - 1, 0, rootIndex); QVERIFY(lastChildIndex.isValid()); QCOMPARE(model->hasChildren(lastChildIndex), true); treeView->expand(4); WAIT_UNTIL_POLISHED; // We now expect root + 4 children + 4 children = 9 rows const int rowCount = treeViewPrivate->loadedRows.count(); QCOMPARE(rowCount, 9); // Go through all rows in the view, except the root for (int row = 1; row < rowCount; ++row) { const auto childFxItem = treeViewPrivate->loadedTableItem(QPoint(0, row)); QVERIFY(childFxItem); const auto childItem = qobject_cast(childFxItem->item); QVERIFY(childItem); QCOMPARE(childItem->treeView(), treeView); QCOMPARE(childItem->isTreeNode(), true); QCOMPARE(childItem->expanded(), row == 4); QCOMPARE(childItem->hasChildren(), row == 4 || row == 8); QCOMPARE(childItem->depth(), row <= 4 ? 1 : 2); QCOMPARE(childItem->current(), false); QCOMPARE(childItem->selected(), false); QCOMPARE(childItem->editing(), false); QCOMPARE(childItem->leftPadding(), childItem->leftMargin() + (childItem->depth() * childItem->indentation()) + childItem->indicator()->width() + childItem->spacing()); QCOMPARE(childItem->indicator()->x(), childItem->leftMargin() + (childItem->depth() * childItem->indentation())); } } void tst_qquicktreeviewdelegate::checkCurrentIndex() { // Check that that a cell becomes current when you click on it LOAD_TREEVIEW("unmodified.qml"); // Check that the view only has one row loaded so far (the root of the tree) QCOMPARE(treeViewPrivate->loadedRows.count(), 1); const QPoint cell(0, 0); const auto item = qobject_cast(treeView->itemAtCell(cell)); QVERIFY(item); QVERIFY(!item->current()); QVERIFY(!item->selected()); QVERIFY(!item->editing()); QVERIFY(!treeView->hasActiveFocus()); // Click on the label QPoint localPos = QPoint(item->width() / 2, item->height() / 2); QPoint pos = item->window()->contentItem()->mapFromItem(item, localPos).toPoint(); QTest::mouseClick(item->window(), Qt::LeftButton, Qt::NoModifier, pos); QVERIFY(item->current()); QVERIFY(!item->selected()); QVERIFY(!item->editing()); QVERIFY_ACTIVE_FOCUS(treeView); // Select the cell treeView->selectionModel()->setCurrentIndex(treeView->modelIndex(cell), QItemSelectionModel::Select); QVERIFY(item->current()); QVERIFY(item->selected()); QVERIFY(!item->editing()); } void tst_qquicktreeviewdelegate::checkClickedSignal_data() { QTest::addColumn("pointerNavigationEnabled"); QTest::newRow("pointer navigation enabled") << true; QTest::newRow("pointer navigation disabled") << false; } void tst_qquicktreeviewdelegate::checkClickedSignal() { // Check that the delegate emits clicked when clicking on the // label, but not when clicking on the indicator. This API is // a part of the AbstractButton API, and should work with or // without TableView.pointerNavigationEnabled set. QFETCH(bool, pointerNavigationEnabled); LOAD_TREEVIEW("unmodified.qml"); treeView->setPointerNavigationEnabled(pointerNavigationEnabled); const auto item = treeView->itemAtIndex(treeView->index(0, 0)); QVERIFY(item); QSignalSpy clickedSpy(item, SIGNAL(clicked())); // Click on the label QPoint localPos = QPoint(item->width() / 2, item->height() / 2); QPoint pos = item->window()->contentItem()->mapFromItem(item, localPos).toPoint(); QTest::mouseClick(item->window(), Qt::LeftButton, Qt::NoModifier, pos); QCOMPARE(clickedSpy.size(), 1); clickedSpy.clear(); // Click on the indicator const auto indicator = item->property("indicator").value(); QVERIFY(indicator); localPos = QPoint(indicator->x() + indicator->width() / 2, indicator->y() + indicator->height() / 2); pos = item->window()->contentItem()->mapFromItem(item, localPos).toPoint(); QTest::mouseClick(item->window(), Qt::LeftButton, Qt::NoModifier, pos); QCOMPARE(clickedSpy.size(), 0); } void tst_qquicktreeviewdelegate::clearSelectionOnClick() { LOAD_TREEVIEW("unmodified.qml"); // Select root item const auto index = treeView->selectionModel()->model()->index(0, 0); treeView->selectionModel()->select(index, QItemSelectionModel::Select); QCOMPARE(treeView->selectionModel()->selectedIndexes().size(), 1); // Click on a cell. This should remove the selection const auto item = qobject_cast(treeView->itemAtIndex(treeView->index(0, 0))); QVERIFY(item); QPoint localPos = QPoint(item->width() / 2, item->height() / 2); QPoint pos = item->window()->contentItem()->mapFromItem(item, localPos).toPoint(); QTest::mouseClick(item->window(), Qt::LeftButton, Qt::NoModifier, pos); QCOMPARE(treeView->selectionModel()->selectedIndexes().size(), 0); } void tst_qquicktreeviewdelegate::dragToSelect() { // Check that the delegate is not blocking the user from // being able to select cells using Drag. LOAD_TREEVIEW("unmodified.qml"); // When TreeView is not interactive, SelectionRectangle // will use Drag by default. treeView->setInteractive(false); treeView->expandRecursively(); WAIT_UNTIL_POLISHED; QVERIFY(!treeView->selectionModel()->hasSelection()); QCOMPARE(treeView->selectionBehavior(), QQuickTableView::SelectRows); // Drag on from cell 0,0 to 0,1 const auto item0_0 = treeView->itemAtIndex(treeView->index(0, 0)); const auto item0_1 = treeView->itemAtIndex(treeView->index(1, 0)); QVERIFY(item0_0); QVERIFY(item0_1); QQuickWindow *window = treeView->window(); QPoint localPos0_0 = QPoint(item0_0->width() / 2, item0_0->height() / 2); QPoint windowPos0_0 = window->contentItem()->mapFromItem(item0_0, localPos0_0).toPoint(); QPoint localPos0_1 = QPoint(item0_1->width() / 2, item0_1->height() / 2); QPoint windowPos0_1 = window->contentItem()->mapFromItem(item0_1, localPos0_1).toPoint(); QTest::mousePress(window, Qt::LeftButton, Qt::NoModifier, windowPos0_0); QTest::mouseMove(window, windowPos0_1); QTest::mouseRelease(window, Qt::LeftButton, Qt::NoModifier, windowPos0_1); // Since TreeView uses TableView.SelectRows by default, we // now expect cells from 0,0 and 1,1 to be selected. QCOMPARE(treeView->selectionModel()->selectedIndexes().size(), 4); } void tst_qquicktreeviewdelegate::pressAndHoldToSelect() { // Check that the delegate is not blocking the user from // being able to select cells using PressAndHold LOAD_TREEVIEW("unmodified.qml"); // When TreeView is interactive, SelectionRectangle // will use PressAndHold by default. treeView->setInteractive(true); treeView->expandRecursively(); WAIT_UNTIL_POLISHED; QVERIFY(!treeView->selectionModel()->hasSelection()); QCOMPARE(treeView->selectionBehavior(), QQuickTableView::SelectRows); // PressAndHold on cell 0,0 const auto item0_0 = treeView->itemAtIndex(treeView->index(0, 0)); QVERIFY(item0_0); QQuickWindow *window = treeView->window(); QPoint localPos0_0 = QPoint(item0_0->width() / 2, item0_0->height() / 2); QPoint windowPos0_0 = window->contentItem()->mapFromItem(item0_0, localPos0_0).toPoint(); QTest::mousePress(window, Qt::LeftButton, Qt::NoModifier, windowPos0_0); QTRY_VERIFY(treeView->selectionModel()->hasSelection()); // Since TreeView uses TableView.SelectRows by default, we // now expect both cell 0,0 and 1,0 to be selected. QCOMPARE(treeView->selectionModel()->selectedIndexes().size(), 2); QTest::mouseRelease(window, Qt::LeftButton, Qt::NoModifier, windowPos0_0); } QTEST_MAIN(tst_qquicktreeviewdelegate) #include "tst_qquicktreeviewdelegate.moc"