Add scale to scatter itemHEADdev

Also update ItemModelScatterDataProxy and ScatterItemModelHandler.
Added manual test for vector fields.

Fixes: QTBUG-134242
Task-number: QTBUG-134558
Change-Id: Ie4f128419ea176d1b8e0f8e874f447ce7fb35b39
Reviewed-by: Sami Varanka <[email protected]>

7 files changed, 280 insertions, 3 deletions

diff --git a/src/graphs3d/data/qitemmodelscatterdataproxy.cpp b/src/graphs3d/data/qitemmodelscatterdataproxy.cpp
index 064a6c37..1e19b692 100644
--- a/src/graphs3d/data/qitemmodelscatterdataproxy.cpp
+++ b/src/graphs3d/data/qitemmodelscatterdataproxy.cpp
@@ -106,6 +106,14 @@ QT_BEGIN_NAMESPACE
  */
 
 /*!
+ * \qmlproperty string ItemModelScatterDataProxy::scaleRole
+ *
+ * The model may supply the value for scale as either a variant that is
+ * \c{"x,y,z"}. The first will construct the
+ * vector3d directly with the given values.
+ */
+
+/*!
  * \qmlproperty regExp ItemModelScatterDataProxy::xPosRolePattern
  *
  * When set, a search and replace is done on the value mapped by the x-position
@@ -153,6 +161,17 @@ QT_BEGIN_NAMESPACE
  */
 
 /*!
+ * \qmlproperty regExp ItemModelScatterDataProxy::scaleRolePattern
+ * When set, a search and replace is done on the value mapped by the scale
+ * role before it is used
+ * as item scale. This property specifies the regular expression to find the
+ * portion of the mapped value to replace, and scaleRoleReplace property
+ * contains the replacement string.
+ *
+ * \sa scaleRole, scaleRoleReplace
+ */
+
+/*!
  * \qmlproperty string ItemModelScatterDataProxy::xPosRoleReplace
  *
  * This property defines the replacement content to be used in conjunction with
@@ -200,6 +219,17 @@ QT_BEGIN_NAMESPACE
  */
 
 /*!
+ * \qmlproperty string ItemModelScatterDataProxy::scaleRoleReplace
+ * This property defines the replacement content to be used in conjunction with
+ * scaleRolePattern. Defaults to an empty string. For more information on how
+ * the search and replace using regular expressions works, see
+ * the QString::replace(const QRegularExpression &rx, const QString &after)
+ * function documentation.
+ *
+ * \sa scaleRole, scaleRolePattern
+ */
+
+/*!
     \qmlsignal ItemModelScatterDataProxy::itemModelChanged(model itemModel)
 
     This signal is emitted when itemModel changes to \a itemModel.
@@ -230,6 +260,12 @@ QT_BEGIN_NAMESPACE
 */
 
 /*!
+    \qmlsignal ItemModelScatterDataProxy::scaleRoleChanged(string role)
+
+    This signal is emitted when scaleRole changes to \a role.
+*/
+
+/*!
     \qmlsignal ItemModelScatterDataProxy::xPosRolePatternChanged(regExp pattern)
 
     This signal is emitted when xPosRolePattern changes to \a pattern.
@@ -254,12 +290,24 @@ QT_BEGIN_NAMESPACE
 */
 
 /*!
+    \qmlsignal ItemModelScatterDataProxy::scaleRolePatternChanged(regExp pattern)
+
+    This signal is emitted when scaleRolePattern changes to \a pattern.
+*/
+
+/*!
     \qmlsignal ItemModelScatterDataProxy::rotationRoleReplaceChanged(string replace)
 
     This signal is emitted when rotationRoleReplace changes to \a replace.
 */
 
 /*!
+    \qmlsignal ItemModelScatterDataProxy::scaleRoleReplaceChanged(string replace)
+
+    This signal is emitted when scaleRoleReplace changes to \a replace.
+*/
+
+/*!
     \qmlsignal ItemModelScatterDataProxy::xPosRoleReplaceChanged(string replace)
 
     This signal is emitted when xPosRoleReplace changes to \a replace.
@@ -348,6 +396,33 @@ QItemModelScatterDataProxy::QItemModelScatterDataProxy(QAbstractItemModel *itemM
 }
 
 /*!
+ * Constructs QItemModelScatterDataProxy with \a itemModel and an optional \a
+ * parent. The proxy doesn't take ownership of the \a itemModel, as item models
+ * are typically owned by other controls. The xPosRole property is set to \a
+ * xPosRole, the yPosRole property to \a yPosRole, the zPosRole property to \a
+ * zPosRole, the rotation property to \a rotationRole, and the scale role
+ * property to \a scaleRole.
+ */
+QItemModelScatterDataProxy::QItemModelScatterDataProxy(QAbstractItemModel *itemModel,
+                                                       const QString &xPosRole,
+                                                       const QString &yPosRole,
+                                                       const QString &zPosRole,
+                                                       const QString &rotationRole,
+                                                       const QString &scaleRole,
+                                                       QObject *parent)
+    : QScatterDataProxy(*(new QItemModelScatterDataProxyPrivate(this)), parent)
+{
+    Q_D(QItemModelScatterDataProxy);
+    d->m_itemModelHandler->setItemModel(itemModel);
+    d->m_xPosRole = xPosRole;
+    d->m_yPosRole = yPosRole;
+    d->m_zPosRole = zPosRole;
+    d->m_rotationRole = rotationRole;
+    d->m_scaleRole = scaleRole;
+    d->connectItemModelHandler();
+}
+
+/*!
  * Destroys QItemModelScatterDataProxy.
  */
 QItemModelScatterDataProxy::~QItemModelScatterDataProxy() {}
@@ -473,6 +548,30 @@ QString QItemModelScatterDataProxy::rotationRole() const
 }
 
 /*!
+ * \property QItemModelScatterDataProxy::scaleRole
+ *
+ * \brief The item model role to map into item scale.
+ *
+ * The model may supply the value for scale as either a variant that is
+ * \c{"x,y,z"}. The first will construct the
+ * vector3d directly with the given values.
+ */
+void QItemModelScatterDataProxy::setScaleRole(const QString &role)
+{
+    Q_D(QItemModelScatterDataProxy);
+    if (d->m_scaleRole != role) {
+        d->m_scaleRole = role;
+        emit scaleRoleChanged(role);
+    }
+}
+
+QString QItemModelScatterDataProxy::scaleRole() const
+{
+    Q_D(const QItemModelScatterDataProxy);
+    return d->m_scaleRole;
+}
+
+/*!
  * \property QItemModelScatterDataProxy::xPosRolePattern
  *
  * \brief Whether search and replace is done on the value mapped by the x
@@ -593,6 +692,33 @@ QRegularExpression QItemModelScatterDataProxy::rotationRolePattern() const
 }
 
 /*!
+ * \property QItemModelScatterDataProxy::scaleRolePattern
+ *
+ * \brief Whether a search and replace is done on the value mapped by the
+ * scale role before it is used as item scale.
+ *
+ * This property specifies the regular expression to find the portion
+ * of the mapped value to replace and scaleRoleReplace property contains the
+ * replacement string.
+ *
+ * \sa scaleRole, scaleRoleReplace
+ */
+void QItemModelScatterDataProxy::setScaleRolePattern(const QRegularExpression &pattern)
+{
+    Q_D(QItemModelScatterDataProxy);
+    if (d->m_scaleRolePattern != pattern) {
+        d->m_scaleRolePattern = pattern;
+        emit scaleRolePatternChanged(pattern);
+    }
+}
+
+QRegularExpression QItemModelScatterDataProxy::scaleRolePattern() const
+{
+    Q_D(const QItemModelScatterDataProxy);
+    return d->m_scaleRolePattern;
+}
+
+/*!
  * \property QItemModelScatterDataProxy::xPosRoleReplace
  *
  * \brief The replace content to be used in conjunction with the x position role
@@ -713,17 +839,46 @@ QString QItemModelScatterDataProxy::rotationRoleReplace() const
 }
 
 /*!
- * Changes \a xPosRole, \a yPosRole, \a zPosRole, and \a rotationRole mapping.
+ * \property QItemModelScatterDataProxy::scaleRoleReplace
+ *
+ * \brief The replace content to be used in conjunction with the scale role
+ * pattern.
+ *
+ * Defaults to an empty string. For more information on how the search and
+ * replace using regular expressions works, see QString::replace(const
+ * QRegularExpression &rx, const QString &after) function documentation.
+ *
+ * \sa scaleRole, scaleRolePattern
+ */
+void QItemModelScatterDataProxy::setScaleRoleReplace(const QString &replace)
+{
+    Q_D(QItemModelScatterDataProxy);
+    if (d->m_scaleRoleReplace != replace) {
+        d->m_scaleRoleReplace = replace;
+        emit scaleRoleReplaceChanged(replace);
+    }
+}
+
+QString QItemModelScatterDataProxy::scaleRoleReplace() const
+{
+    Q_D(const QItemModelScatterDataProxy);
+    return d->m_scaleRoleReplace;
+}
+
+/*!
+ * Changes \a xPosRole, \a yPosRole, \a zPosRole, \a rotationRole, and \a scaleRole mapping.
  */
 void QItemModelScatterDataProxy::remap(const QString &xPosRole,
                                        const QString &yPosRole,
                                        const QString &zPosRole,
-                                       const QString &rotationRole)
+                                       const QString &rotationRole,
+                                       const QString &scaleRole)
 {
     setXPosRole(xPosRole);
     setYPosRole(yPosRole);
     setZPosRole(zPosRole);
     setRotationRole(rotationRole);
+    setScaleRole(scaleRole);
 }
 
 // QItemModelScatterDataProxyPrivate
@@ -761,6 +916,10 @@ void QItemModelScatterDataProxyPrivate::connectItemModelHandler()
                      m_itemModelHandler,
                      &AbstractItemModelHandler::handleMappingChanged);
     QObject::connect(q,
+                     &QItemModelScatterDataProxy::scaleRoleChanged,
+                     m_itemModelHandler,
+                     &AbstractItemModelHandler::handleMappingChanged);
+    QObject::connect(q,
                      &QItemModelScatterDataProxy::xPosRolePatternChanged,
                      m_itemModelHandler,
                      &AbstractItemModelHandler::handleMappingChanged);
@@ -777,6 +936,10 @@ void QItemModelScatterDataProxyPrivate::connectItemModelHandler()
                      m_itemModelHandler,
                      &AbstractItemModelHandler::handleMappingChanged);
     QObject::connect(q,
+                     &QItemModelScatterDataProxy::scaleRolePatternChanged,
+                     m_itemModelHandler,
+                     &AbstractItemModelHandler::handleMappingChanged);
+    QObject::connect(q,
                      &QItemModelScatterDataProxy::xPosRoleReplaceChanged,
                      m_itemModelHandler,
                      &AbstractItemModelHandler::handleMappingChanged);
@@ -792,6 +955,10 @@ void QItemModelScatterDataProxyPrivate::connectItemModelHandler()
                      &QItemModelScatterDataProxy::rotationRoleReplaceChanged,
                      m_itemModelHandler,
                      &AbstractItemModelHandler::handleMappingChanged);
+    QObject::connect(q,
+                     &QItemModelScatterDataProxy::scaleRoleReplaceChanged,
+                     m_itemModelHandler,
+                     &AbstractItemModelHandler::handleMappingChanged);
 }
 
 QT_END_NAMESPACE
diff --git a/src/graphs3d/data/qitemmodelscatterdataproxy.h b/src/graphs3d/data/qitemmodelscatterdataproxy.h
index b600d790..fb76cc2f 100644
--- a/src/graphs3d/data/qitemmodelscatterdataproxy.h
+++ b/src/graphs3d/data/qitemmodelscatterdataproxy.h
@@ -24,6 +24,8 @@ class Q_GRAPHS_EXPORT QItemModelScatterDataProxy : public QScatterDataProxy
     Q_PROPERTY(QString zPosRole READ zPosRole WRITE setZPosRole NOTIFY zPosRoleChanged FINAL)
     Q_PROPERTY(QString rotationRole READ rotationRole WRITE setRotationRole NOTIFY
                    rotationRoleChanged FINAL)
+    Q_PROPERTY(QString scaleRole READ scaleRole WRITE setScaleRole NOTIFY
+                   scaleRoleChanged FINAL REVISION(6, 10))
     Q_PROPERTY(QRegularExpression xPosRolePattern READ xPosRolePattern WRITE setXPosRolePattern
                    NOTIFY xPosRolePatternChanged FINAL)
     Q_PROPERTY(QRegularExpression yPosRolePattern READ yPosRolePattern WRITE setYPosRolePattern
@@ -32,6 +34,8 @@ class Q_GRAPHS_EXPORT QItemModelScatterDataProxy : public QScatterDataProxy
                    NOTIFY zPosRolePatternChanged FINAL)
     Q_PROPERTY(QRegularExpression rotationRolePattern READ rotationRolePattern WRITE
                    setRotationRolePattern NOTIFY rotationRolePatternChanged FINAL)
+    Q_PROPERTY(QRegularExpression scaleRolePattern READ scaleRolePattern WRITE
+                   setScaleRolePattern NOTIFY scaleRolePatternChanged FINAL REVISION (6, 10))
     Q_PROPERTY(QString xPosRoleReplace READ xPosRoleReplace WRITE setXPosRoleReplace NOTIFY
                    xPosRoleReplaceChanged FINAL)
     Q_PROPERTY(QString yPosRoleReplace READ yPosRoleReplace WRITE setYPosRoleReplace NOTIFY
@@ -40,6 +44,8 @@ class Q_GRAPHS_EXPORT QItemModelScatterDataProxy : public QScatterDataProxy
                    zPosRoleReplaceChanged FINAL)
     Q_PROPERTY(QString rotationRoleReplace READ rotationRoleReplace WRITE setRotationRoleReplace
                    NOTIFY rotationRoleReplaceChanged FINAL)
+    Q_PROPERTY(QString scaleRoleReplace READ scaleRoleReplace WRITE setScaleRoleReplace
+                   NOTIFY scaleRoleReplaceChanged FINAL REVISION (6, 10))
     QML_NAMED_ELEMENT(ItemModelScatterDataProxy)
 
 public:
@@ -56,6 +62,13 @@ public:
                                         const QString &zPosRole,
                                         const QString &rotationRole,
                                         QObject *parent = nullptr);
+    explicit QItemModelScatterDataProxy(QAbstractItemModel *itemModel,
+                                        const QString &xPosRole,
+                                        const QString &yPosRole,
+                                        const QString &zPosRole,
+                                        const QString &rotationRole,
+                                        const QString &scaleRole,
+                                        QObject *parent = nullptr);
     ~QItemModelScatterDataProxy() override;
 
     void setItemModel(QAbstractItemModel *itemModel);
@@ -69,11 +82,14 @@ public:
     QString zPosRole() const;
     void setRotationRole(const QString &role);
     QString rotationRole() const;
+    void setScaleRole(const QString &role);
+    QString scaleRole() const;
 
     void remap(const QString &xPosRole,
                const QString &yPosRole,
                const QString &zPosRole,
-               const QString &rotationRole);
+               const QString &rotationRole,
+               const QString &scaleRole);
 
     void setXPosRolePattern(const QRegularExpression &pattern);
     QRegularExpression xPosRolePattern() const;
@@ -83,6 +99,8 @@ public:
     QRegularExpression zPosRolePattern() const;
     void setRotationRolePattern(const QRegularExpression &pattern);
     QRegularExpression rotationRolePattern() const;
+    void setScaleRolePattern(const QRegularExpression &pattern);
+    QRegularExpression scaleRolePattern() const;
 
     void setXPosRoleReplace(const QString &replace);
     QString xPosRoleReplace() const;
@@ -92,6 +110,8 @@ public:
     QString zPosRoleReplace() const;
     void setRotationRoleReplace(const QString &replace);
     QString rotationRoleReplace() const;
+    void setScaleRoleReplace(const QString &replace);
+    QString scaleRoleReplace() const;
 
 Q_SIGNALS:
     void itemModelChanged(const QAbstractItemModel *itemModel);
@@ -99,14 +119,17 @@ Q_SIGNALS:
     void yPosRoleChanged(const QString &role);
     void zPosRoleChanged(const QString &role);
     void rotationRoleChanged(const QString &role);
+    void scaleRoleChanged(const QString &role);
     void xPosRolePatternChanged(const QRegularExpression &pattern);
     void yPosRolePatternChanged(const QRegularExpression &pattern);
     void zPosRolePatternChanged(const QRegularExpression &pattern);
     void rotationRolePatternChanged(const QRegularExpression &pattern);
+    void scaleRolePatternChanged(const QRegularExpression &pattern);
     void rotationRoleReplaceChanged(const QString &replace);
     void xPosRoleReplaceChanged(const QString &replace);
     void yPosRoleReplaceChanged(const QString &replace);
     void zPosRoleReplaceChanged(const QString &replace);
+    void scaleRoleReplaceChanged(const QString &replace);
 
 private:
     Q_DISABLE_COPY(QItemModelScatterDataProxy)
diff --git a/src/graphs3d/data/qitemmodelscatterdataproxy_p.h b/src/graphs3d/data/qitemmodelscatterdataproxy_p.h
index 9bd63677..f4fb09ec 100644
--- a/src/graphs3d/data/qitemmodelscatterdataproxy_p.h
+++ b/src/graphs3d/data/qitemmodelscatterdataproxy_p.h
@@ -37,16 +37,19 @@ private:
     QString m_yPosRole;
     QString m_zPosRole;
     QString m_rotationRole;
+    QString m_scaleRole;
 
     QRegularExpression m_xPosRolePattern;
     QRegularExpression m_yPosRolePattern;
     QRegularExpression m_zPosRolePattern;
     QRegularExpression m_rotationRolePattern;
+    QRegularExpression m_scaleRolePattern;
 
     QString m_xPosRoleReplace;
     QString m_yPosRoleReplace;
     QString m_zPosRoleReplace;
     QString m_rotationRoleReplace;
+    QString m_scaleRoleReplace;
 };
 
 QT_END_NAMESPACE
diff --git a/src/graphs3d/data/qscatterdataitem.cpp b/src/graphs3d/data/qscatterdataitem.cpp
index 8d6b327d..f0c0d069 100644
--- a/src/graphs3d/data/qscatterdataitem.cpp
+++ b/src/graphs3d/data/qscatterdataitem.cpp
@@ -37,6 +37,18 @@
  */
 
 /*!
+ * \fn QScatterDataItem::QScatterDataItem(QVector3D position, const QVector3D &scale)
+ * Constructs scatter data item with position \a position
+ * and scale \a scale.
+ */
+
+/*!
+ * \fn QScatterDataItem::QScatterDataItem(QVector3D position, const QQuaternion &rotation, const QVector3D &scale)
+ * Constructs scatter data item with position \a position,
+ * rotation \a rotation, and scale \a scale.
+ */
+
+/*!
  * \fn void QScatterDataItem::setPosition(QVector3D pos)
  * Sets the position \a pos for this data item.
  */
@@ -61,6 +73,19 @@
  */
 
 /*!
+ * \fn void QScatterDataItem::setScale(const QVector3D &scale)
+ * Sets the scale \a scale for this data item.
+ * If the series also has itemSize, scale is multiplied by it.
+ * Defaults to QVector3D(1,1,1).
+ */
+
+/*!
+ * \fn QQuaternion QScatterDataItem::scale() const
+ * Returns the scale of this data item.
+ * \sa setScale()
+ */
+
+/*!
  * \fn void QScatterDataItem::setX(float value)
  * Sets the x-coordinate of the item position to the value \a value.
  */
diff --git a/src/graphs3d/data/qscatterdataitem.h b/src/graphs3d/data/qscatterdataitem.h
index ac685aa8..c34672ee 100644
--- a/src/graphs3d/data/qscatterdataitem.h
+++ b/src/graphs3d/data/qscatterdataitem.h
@@ -24,10 +24,22 @@ public:
         , m_rotation(rotation)
     {}
 
+    explicit QScatterDataItem(QVector3D position, const QVector3D &scale) noexcept
+        : m_position(position)
+        , m_scale(scale)
+    {}
+    explicit QScatterDataItem(QVector3D position, const QQuaternion &rotation, const QVector3D &scale) noexcept
+        : m_position(position)
+        , m_rotation(rotation)
+        , m_scale(scale)
+    {}
+
     void setPosition(QVector3D pos) noexcept { m_position = pos; }
     QVector3D position() const noexcept { return m_position; }
     void setRotation(const QQuaternion &rot) noexcept { m_rotation = rot; }
     QQuaternion rotation() const { return m_rotation; }
+    void setScale(const QVector3D &scale) noexcept { m_scale = scale; }
+    QVector3D scale() const noexcept { return m_scale; }
     void setX(float value) noexcept { m_position.setX(value); }
     void setY(float value) noexcept { m_position.setY(value); }
     void setZ(float value) noexcept { m_position.setZ(value); }
@@ -38,6 +50,7 @@ public:
 private:
     QVector3D m_position = {};
     QQuaternion m_rotation = {};
+    QVector3D m_scale = QVector3D(1,1,1);
     Q_DECL_UNUSED_MEMBER quintptr reserved = 0;
 };
 
diff --git a/src/graphs3d/data/scatteritemmodelhandler.cpp b/src/graphs3d/data/scatteritemmodelhandler.cpp
index cb9dfc8a..14239ffb 100644
--- a/src/graphs3d/data/scatteritemmodelhandler.cpp
+++ b/src/graphs3d/data/scatteritemmodelhandler.cpp
@@ -14,10 +14,12 @@ ScatterItemModelHandler::ScatterItemModelHandler(QItemModelScatterDataProxy *pro
     , m_yPosRole(noRoleIndex)
     , m_zPosRole(noRoleIndex)
     , m_rotationRole(noRoleIndex)
+    , m_scaleRole(noRoleIndex)
     , m_haveXPosPattern(false)
     , m_haveYPosPattern(false)
     , m_haveZPosPattern(false)
     , m_haveRotationPattern(false)
+    , m_haveScalePattern(false)
 {}
 
 ScatterItemModelHandler::~ScatterItemModelHandler() {}
@@ -117,6 +119,32 @@ static inline QQuaternion toQuaternion(const QVariant &variant)
     return QQuaternion();
 }
 
+static inline QVector3D toVector3D(const QVariant &variant)
+{
+    if (variant.canConvert<QVector3D>()) {
+        return variant.value<QVector3D>();
+    } else if (variant.canConvert<QString>()) {
+        QString s = variant.toString();
+        if (!s.isEmpty()) {
+            if (s.count(QLatin1Char(',')) == 2) {
+                qsizetype index = s.indexOf(QLatin1Char(','));
+                qsizetype index2 = s.indexOf(QLatin1Char(','), index + 1);
+
+                bool xGood, yGood, zGood;
+                float xCoord = s.left(index).toFloat(&xGood);
+                float yCoord = s.mid(index + 1, index2 - index - 1).toFloat(&yGood);
+                float zCoord = s.mid(index2 + 1).toFloat(&zGood);
+
+                if (xGood && yGood && zGood) {
+                        return QVector3D(xCoord, yCoord, zCoord);
+                }
+            }
+        }
+    }
+    return QVector3D();
+
+}
+
 void ScatterItemModelHandler::modelPosToScatterItem(int modelRow,
                                                     int modelColumn,
                                                     QScatterDataItem &item)
@@ -161,6 +189,15 @@ void ScatterItemModelHandler::modelPosToScatterItem(int modelRow,
             item.setRotation(toQuaternion(rotationVar));
         }
     }
+    if (m_scaleRole != noRoleIndex) {
+        QVariant scaleVar = index.data(m_scaleRole);
+        if (m_haveScalePattern) {
+            item.setScale(toVector3D(
+                QVariant(scaleVar.toString().replace(m_scalePattern, m_scaleReplace))));
+        } else {
+            item.setScale(toVector3D(scaleVar));
+        }
+    }
 
     item.setPosition(QVector3D(xPos, yPos, zPos));
 }
@@ -179,21 +216,26 @@ void ScatterItemModelHandler::resolveModel()
     m_yPosPattern = m_proxy->yPosRolePattern();
     m_zPosPattern = m_proxy->zPosRolePattern();
     m_rotationPattern = m_proxy->rotationRolePattern();
+    m_scalePattern = m_proxy->scaleRolePattern();
     m_xPosReplace = m_proxy->xPosRoleReplace();
     m_yPosReplace = m_proxy->yPosRoleReplace();
     m_zPosReplace = m_proxy->zPosRoleReplace();
     m_rotationReplace = m_proxy->rotationRoleReplace();
+    m_scaleReplace = m_proxy->scaleRoleReplace();
     m_haveXPosPattern = !m_xPosPattern.namedCaptureGroups().isEmpty() && m_xPosPattern.isValid();
     m_haveYPosPattern = !m_yPosPattern.namedCaptureGroups().isEmpty() && m_yPosPattern.isValid();
     m_haveZPosPattern = !m_zPosPattern.namedCaptureGroups().isEmpty() && m_zPosPattern.isValid();
     m_haveRotationPattern = !m_rotationPattern.namedCaptureGroups().isEmpty()
                             && m_rotationPattern.isValid();
+    m_haveScalePattern = !m_scalePattern.namedCaptureGroups().isEmpty()
+                            && m_scalePattern.isValid();
 
     QHash<int, QByteArray> roleHash = m_itemModel->roleNames();
     m_xPosRole = roleHash.key(m_proxy->xPosRole().toLatin1(), noRoleIndex);
     m_yPosRole = roleHash.key(m_proxy->yPosRole().toLatin1(), noRoleIndex);
     m_zPosRole = roleHash.key(m_proxy->zPosRole().toLatin1(), noRoleIndex);
     m_rotationRole = roleHash.key(m_proxy->rotationRole().toLatin1(), noRoleIndex);
+    m_scaleRole = roleHash.key(m_proxy->scaleRole().toLatin1(), noRoleIndex);
     const int columnCount = m_itemModel->columnCount();
     const int rowCount = m_itemModel->rowCount();
     const int totalCount = rowCount * columnCount;
diff --git a/src/graphs3d/data/scatteritemmodelhandler_p.h b/src/graphs3d/data/scatteritemmodelhandler_p.h
index 26c46862..b64c1914 100644
--- a/src/graphs3d/data/scatteritemmodelhandler_p.h
+++ b/src/graphs3d/data/scatteritemmodelhandler_p.h
@@ -45,18 +45,22 @@ private:
     int m_yPosRole;
     int m_zPosRole;
     int m_rotationRole;
+    int m_scaleRole;
     QRegularExpression m_xPosPattern;
     QRegularExpression m_yPosPattern;
     QRegularExpression m_zPosPattern;
     QRegularExpression m_rotationPattern;
+    QRegularExpression m_scalePattern;
     QString m_xPosReplace;
     QString m_yPosReplace;
     QString m_zPosReplace;
     QString m_rotationReplace;
+    QString m_scaleReplace;
     bool m_haveXPosPattern;
     bool m_haveYPosPattern;
     bool m_haveZPosPattern;
     bool m_haveRotationPattern;
+    bool m_haveScalePattern;
 };
 
 QT_END_NAMESPACE