aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJukka Jokiniva <[email protected]>2024-02-16 16:12:55 +0200
committerJukka Jokiniva <[email protected]>2024-03-26 09:51:21 +0000
commitfeaa19a6558bfca1f32f9bf22500775d36d41c78 (patch)
tree6343aebd393de707434b5fd9da9df982c8738305
parent0bb47bd57777320804b08a3a4d2e406939e5deba (diff)
Escape info banner messageHEADdev
Change-Id: Ib1155e101c0302320087d5b6c151eb74aa58b2ce Reviewed-by: Daniel Smith <[email protected]>
-rw-r--r--BUILD1
-rw-r--r--pom.xml6
-rw-r--r--src/main/java/org/qtproject/codereview/gerritinfobanner/MessageStore.java5
3 files changed, 10 insertions, 2 deletions
diff --git a/BUILD b/BUILD
index 5bf8a19..5e0164b 100644
--- a/BUILD
+++ b/BUILD
@@ -14,6 +14,7 @@ gerrit_plugin(
],
resource_jars = [":banner-info-ui"],
resources = glob(["src/main/resources/**/*"]),
+ deps = ["@commons-text//jar"],
)
gerrit_js_bundle(
diff --git a/pom.xml b/pom.xml
index 50deb02..9569efa 100644
--- a/pom.xml
+++ b/pom.xml
@@ -75,6 +75,12 @@ Copyright (C) 2022 The Qt Company
<scope>provided</scope>
</dependency>
<dependency>
+ <groupId>org.apache.commons</groupId>
+ <artifactId>commons-text</artifactId>
+ <version>1.2</version>
+ <scope>provided</scope>
+ </dependency>
+ <dependency>
<groupId>junit</groupId>
<artifactId>junit</artifactId>
<version>4.11</version>
diff --git a/src/main/java/org/qtproject/codereview/gerritinfobanner/MessageStore.java b/src/main/java/org/qtproject/codereview/gerritinfobanner/MessageStore.java
index 2fe4a2a..7136e4b 100644
--- a/src/main/java/org/qtproject/codereview/gerritinfobanner/MessageStore.java
+++ b/src/main/java/org/qtproject/codereview/gerritinfobanner/MessageStore.java
@@ -1,10 +1,11 @@
//
-// Copyright (C) 2022 The Qt Company
+// Copyright (C) 2022-24 The Qt Company
//
package org.qtproject.codereview.gerritinfobanner;
import com.google.inject.Singleton;
+import org.apache.commons.text.StringEscapeUtils;
@Singleton
public class MessageStore {
@@ -16,6 +17,6 @@ public class MessageStore {
}
public void setMessage(String msg) {
- message = msg;
+ message = StringEscapeUtils.escapeHtml4(msg);
}
}