diff options
| author | Peter Eisentraut | 2025-11-11 06:48:54 +0000 |
|---|---|---|
| committer | Peter Eisentraut | 2025-11-11 06:55:10 +0000 |
| commit | d2f24df19b7a42a0944a6926a0ca54168dcefe3a (patch) | |
| tree | fe647c724aaa3a151f704f3958eca53989632ebb | |
| parent | e510378358540703a13b77090a0021853bae0745 (diff) | |
guc_var_compare() is invoked from qsort() on an array of struct
config_generic, but the function accesses these directly as
strings (char *). This relies on the name being the first field, so
this works. But we can write this more clearly by using the struct
and then accessing the field through the struct. Before the
reorganization of the GUC structs (commit a13833c35f9), the old code
was probably more convenient, but now we can write this more clearly
and correctly.
After this change, it is no longer required that the name is the first
field in struct config_generic, so remove that comment.
Reviewed-by: Tom Lane <[email protected]>
Discussion: https://www.postgresql.org/message-id/2c961fa1-14f6-44a2-985c-e30b95654e8d%40eisentraut.org
| -rw-r--r-- | src/backend/utils/misc/guc.c | 6 | ||||
| -rw-r--r-- | src/include/utils/guc_tables.h | 2 |
2 files changed, 4 insertions, 4 deletions
diff --git a/src/backend/utils/misc/guc.c b/src/backend/utils/misc/guc.c index 679846da42c..7e2b17cc04e 100644 --- a/src/backend/utils/misc/guc.c +++ b/src/backend/utils/misc/guc.c @@ -1164,10 +1164,10 @@ find_option(const char *name, bool create_placeholders, bool skip_errors, static int guc_var_compare(const void *a, const void *b) { - const char *namea = **(const char **const *) a; - const char *nameb = **(const char **const *) b; + const struct config_generic *ca = *(const struct config_generic *const *) a; + const struct config_generic *cb = *(const struct config_generic *const *) b; - return guc_name_compare(namea, nameb); + return guc_name_compare(ca->name, cb->name); } /* diff --git a/src/include/utils/guc_tables.h b/src/include/utils/guc_tables.h index bbfcc633014..04cc60eb526 100644 --- a/src/include/utils/guc_tables.h +++ b/src/include/utils/guc_tables.h @@ -249,7 +249,7 @@ struct config_enum struct config_generic { /* constant fields, must be set correctly in initial value: */ - const char *name; /* name of variable - MUST BE FIRST */ + const char *name; /* name of variable */ GucContext context; /* context required to set the variable */ enum config_group group; /* to help organize variables by function */ const char *short_desc; /* short desc. of this variable's purpose */ |