Sanitize the URLs passed to redirect_to to prevent a potential response spli

NZKoz · NZKoz · commit 7282ed863ca7 · 2008-10-14T11:47:27.000+02:00
CGI.rb and mongrel don't do any sanitization of the contents of HTTP headers
diff --git a/actionpack/lib/action_controller/response.rb b/actionpack/lib/action_controller/response.rb
@@ -30,9 +30,9 @@ def charset
 
     def redirect(to_url, response_status)
       self.headers["Status"] = response_status
-      self.headers["Location"] = to_url
+      self.headers["Location"] = to_url.gsub(/[\r\n]/, '')
 
-      self.body = "<html><body>You are being <a href=\"#{to_url}\">redirected</a>.</body></html>"
+      self.body = "<html><body>You are being <a href=\"#{CGI.escapeHTML(to_url)}\">redirected</a>.</body></html>"
     end
 
     def prepare!
