Skip to content

Commit 5d16e0e

Browse files
committed
Better hide methods which are not part of the public API.
From C++ perspective these methods are already not accessible. But code-completion in MSVC does not correctly recognize this.
1 parent ce7432c commit 5d16e0e

File tree

2 files changed

+10
-6
lines changed

2 files changed

+10
-6
lines changed

include/mysqlx/devapi/detail/result.h

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,10 @@ class PUBLIC_API Result_detail
7474
Result_detail(const Result_detail&) = delete;
7575
Result_detail& operator=(const Result_detail&) = delete;
7676

77+
public:
78+
79+
struct INTERNAL Impl;
80+
7781
protected:
7882

7983
Result_detail(common::Result_init&);
@@ -87,13 +91,9 @@ class PUBLIC_API Result_detail
8791

8892
Result_detail& operator=(Result_detail&&);
8993

90-
public:
91-
9294
Result_detail() = default;
9395
virtual ~Result_detail();
9496

95-
struct INTERNAL Impl;
96-
9797
Impl& get_impl();
9898

9999
const Impl& get_impl() const
@@ -115,7 +115,7 @@ class PUBLIC_API Result_detail
115115
bool has_data() const;
116116
bool next_result();
117117

118-
private:
118+
protected:
119119

120120
Impl *m_impl = nullptr;
121121
bool m_owns_impl = false;
@@ -149,6 +149,8 @@ class PUBLIC_API Result_detail
149149

150150
using WarningList = internal::List_initializer<Array_source<Warning_src>>;
151151

152+
protected:
153+
152154
unsigned get_warning_count() const;
153155
Warning get_warning(size_t pos);
154156

@@ -181,7 +183,7 @@ class PUBLIC_API Result_detail
181183
class PUBLIC_API Column_detail
182184
: virtual common::Printable
183185
{
184-
public:
186+
protected:
185187

186188
using Impl = common::Column_info<string>;
187189

include/mysqlx/devapi/detail/session.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -209,6 +209,8 @@ class PUBLIC_API Schema_detail
209209
using TableList = List_initializer<List_source<Table_src>>;
210210
using StringList = List_initializer<List_source<Name_src>>;
211211

212+
protected:
213+
212214
void create_collection(const string &name, bool reuse);
213215
void drop_collection(const string &name);
214216

0 commit comments

Comments
 (0)