Skip to content

Commit 324ee4e

Browse files
author
epriestley
committed
Fix rendering issue for LDAP configuration provider transactions
Summary: Fixes T4290. At least one of the fields (`realname`) may have a list of items, and `strlen(array('first', 'last'))` produces the warning and stack trace in T4290. Test Plan: - Edited `realname` from an array value to an array value. - Hit error. - Applied patch. - No more error. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T4290 Differential Revision: https://secure.phabricator.com/D7905
1 parent 1cb8f0b commit 324ee4e

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/applications/auth/provider/PhabricatorAuthProviderLDAP.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -361,7 +361,7 @@ public function renderConfigPropertyTransactionTitle(
361361
$label);
362362
}
363363

364-
if (!strlen($old)) {
364+
if ($old === null || $old === '') {
365365
return pht(
366366
'%s set the "%s" value to "%s".',
367367
$xaction->renderHandleLink($author_phid),

0 commit comments

Comments
 (0)