More Linting

Lots of things in the example app are now marked with the 'final' modifier, and saveToGallery() is protected in classes that implement it. As well, new suppressions are in a few places.

NEW text is now removed completely. Looks like this has been unused for a long time and it's just stuck around anyway.

Author: almic

MPChartExample/res/drawable/new_background.xml

@@ -23,23 +23,6 @@
         android:layout_marginTop="3dp"
         android:text="Small Text"
         android:textSize="12sp"
-        android:layout_marginRight="10dp"
-        android:layout_toLeftOf="@+id/tvNew"
-        android:layout_toStartOf="@+id/tvNew" />
-
-    <TextView
-        android:padding="7dp"
-        android:layout_width="wrap_content"
-        android:layout_height="wrap_content"
-        android:textAppearance="?android:attr/textAppearanceSmall"
-        android:text="@string/textNew"
-        android:background="@drawable/new_background"
-        android:textColor="@android:color/white"
-        android:id="@+id/tvNew"
-        android:textSize="12sp"
-        android:layout_marginRight="5dp"
-        android:layout_centerVertical="true"
-        android:layout_alignParentRight="true"
-        android:layout_alignParentEnd="true" />
+        android:layout_marginRight="10dp" />
 
 </RelativeLayout>

MPChartExample/res/layout/list_item.xml

@@ -23,20 +23,4 @@
         android:textSize="12sp"
         android:visibility="gone" />
 
-    <TextView
-        android:padding="7dp"
-        android:layout_width="wrap_content"
-        android:layout_height="wrap_content"
-        android:textAppearance="?android:attr/textAppearanceSmall"
-        android:text="@string/textNew"
-        android:background="@drawable/new_background"
-        android:textColor="@android:color/white"
-        android:id="@+id/tvNew"
-        android:textSize="12sp"
-        android:layout_marginRight="5dp"
-        android:layout_centerVertical="true"
-        android:layout_alignParentRight="true"
-        android:layout_alignParentEnd="true"
-        android:visibility="gone" />
-
 </RelativeLayout>

MPChartExample/res/layout/list_item_section.xml

@@ -50,6 +50,5 @@
     <string name="dash">-</string>
     <string name="scrollViewStart">START OF SCROLLVIEW</string>
     <string name="scrollViewEnd">END OF SCROLLVIEW</string>
-    <string name="textNew">NEW</string>
 
 </resources>

MPChartExample/res/values/strings.xml

@@ -202,7 +202,7 @@ public boolean onOptionsItemSelected(MenuItem item) {
     }
 
     @Override
-    public void saveToGallery() {
+    protected void saveToGallery() {
         saveToGallery(chart, "AnotherBarActivity");
     }
 

MPChartExample/src/com/xxmassdeveloper/mpchartexample/AnotherBarActivity.java

@@ -297,7 +297,7 @@ public void onProgressChanged(SeekBar seekBar, int progress, boolean fromUser) {
     }
 
     @Override
-    public void saveToGallery() {
+    protected void saveToGallery() {
         saveToGallery(chart, "BarChartActivity");
     }
 
@@ -307,7 +307,7 @@ public void onStartTrackingTouch(SeekBar seekBar) {}
     @Override
     public void onStopTrackingTouch(SeekBar seekBar) {}
 
-    private RectF onValueSelectedRectF = new RectF();
+    private final RectF onValueSelectedRectF = new RectF();
 
     @Override
     public void onValueSelected(Entry e, Highlight h) {

MPChartExample/src/com/xxmassdeveloper/mpchartexample/BarChartActivity.java

@@ -266,7 +266,7 @@ public boolean onOptionsItemSelected(MenuItem item) {
     }
 
     @Override
-    public void saveToGallery() {
+    protected void saveToGallery() {
         saveToGallery(chart, "BarChartActivityMultiDataset");
     }
 

MPChartExample/src/com/xxmassdeveloper/mpchartexample/BarChartActivityMultiDataset.java

@@ -226,7 +226,7 @@ public void onProgressChanged(SeekBar seekBar, int progress, boolean fromUser) {
     }
 
     @Override
-    public void saveToGallery() {
+    protected void saveToGallery() {
         saveToGallery(chart, "BarChartActivitySinus");
     }
 

MPChartExample/src/com/xxmassdeveloper/mpchartexample/BarChartActivitySinus.java

@@ -148,9 +148,9 @@ private void setData(List<Data> dataList) {
      */
     private class Data {
 
-        String xAxisValue;
-        float yValue;
-        float xValue;
+        final String xAxisValue;
+        final float yValue;
+        final float xValue;
 
         Data(float xValue, float yValue, String xAxisValue) {
             this.xAxisValue = xAxisValue;
@@ -162,7 +162,7 @@ private class Data {
     private class ValueFormatter implements IValueFormatter
     {
 
-        private DecimalFormat mFormat;
+        private final DecimalFormat mFormat;
 
         ValueFormatter() {
             mFormat = new DecimalFormat("######.0");

MPChartExample/src/com/xxmassdeveloper/mpchartexample/BarChartPositiveNegative.java

@@ -226,7 +226,7 @@ public boolean onOptionsItemSelected(MenuItem item) {
     }
 
     @Override
-    public void saveToGallery() {
+    protected void saveToGallery() {
         saveToGallery(chart, "BubbleChartActivity");
     }