Skip to content

Commit 27f6ce2

Browse files
author
Sid Zi
committed
more code quality improvements
1 parent 23210e2 commit 27f6ce2

File tree

12 files changed

+337
-343
lines changed

12 files changed

+337
-343
lines changed

‎app/src/main/java/com/sidzi/circleofmusic/adapters/ChatAdapter.java

Lines changed: 69 additions & 73 deletions
Original file line numberDiff line numberDiff line change
@@ -1,73 +1,69 @@
1-
package com.sidzi.circleofmusic.adapters;
2-
3-
import android.support.v7.widget.RecyclerView;
4-
import android.view.LayoutInflater;
5-
import android.view.View;
6-
import android.view.ViewGroup;
7-
import android.widget.TextView;
8-
9-
import com.sidzi.circleofmusic.R;
10-
import com.sidzi.circleofmusic.entities.ChatMessage;
11-
12-
import java.util.ArrayList;
13-
import java.util.List;
14-
15-
public class ChatAdapter extends RecyclerView.Adapter<ChatAdapter.ViewHolder> {
16-
17-
private List<ChatMessage> chatEntries = new ArrayList<>();
18-
19-
public ChatAdapter() {
20-
super();
21-
}
22-
23-
public void addMessage(String messageString, boolean chatMe) {
24-
if (!messageString.equals("")) {
25-
ChatMessage chatMessage = new ChatMessage(messageString, chatMe);
26-
chatEntries.add(chatMessage);
27-
notifyItemInserted(getItemCount());
28-
}
29-
}
30-
31-
32-
@Override
33-
public ChatAdapter.ViewHolder onCreateViewHolder(ViewGroup parent, int viewType) {
34-
final View view = LayoutInflater.from(parent.getContext()).inflate(R.layout.layout_row_chat, parent, false);
35-
return new ViewHolder(view);
36-
}
37-
38-
@Override
39-
public void onBindViewHolder(ChatAdapter.ViewHolder holder, int position) {
40-
if (chatEntries.get(holder.getAdapterPosition()).isSelf_flag()) {
41-
holder.tvChatMessageLocal.setVisibility(View.VISIBLE);
42-
holder.tvChatMessageLocal.setText(chatEntries.get(holder.getAdapterPosition()).getBody());
43-
holder.tvChatMessageRemote.setVisibility(View.GONE);
44-
45-
} else {
46-
holder.tvChatMessageRemote.setVisibility(View.VISIBLE);
47-
holder.tvChatMessageRemote.setText(chatEntries.get(holder.getAdapterPosition()).getBody());
48-
holder.tvChatMessageLocal.setVisibility(View.GONE);
49-
}
50-
}
51-
52-
@Override
53-
public int getItemCount() {
54-
return chatEntries.size();
55-
}
56-
57-
class ViewHolder extends RecyclerView.ViewHolder implements View.OnClickListener {
58-
TextView tvChatMessageLocal;
59-
TextView tvChatMessageRemote;
60-
61-
ViewHolder(View view) {
62-
super(view);
63-
this.tvChatMessageLocal = (TextView) view.findViewById(R.id.tvChatMessageLocal);
64-
this.tvChatMessageRemote = (TextView) view.findViewById(R.id.tvChatMessageRemote);
65-
view.setOnClickListener(this);
66-
}
67-
68-
@Override
69-
public void onClick(View v) {
70-
71-
}
72-
}
73-
}
1+
//package com.sidzi.circleofmusic.adapters;
2+
//
3+
//import android.support.v7.widget.RecyclerView;
4+
//import android.view.LayoutInflater;
5+
//import android.view.View;
6+
//import android.view.ViewGroup;
7+
//import android.widget.TextView;
8+
//
9+
//import com.sidzi.circleofmusic.R;
10+
//import com.sidzi.circleofmusic.entities.ChatMessage;
11+
//
12+
//import java.util.ArrayList;
13+
//import java.util.List;
14+
//
15+
//public class ChatAdapter extends RecyclerView.Adapter<ChatAdapter.ViewHolder> {
16+
//
17+
// private List<ChatMessage> chatEntries = new ArrayList<>();
18+
//
19+
// public void addMessage(String messageString, boolean chatMe) {
20+
// if (!"".equals(messageString)) {
21+
// ChatMessage chatMessage = new ChatMessage(messageString, chatMe);
22+
// chatEntries.add(chatMessage);
23+
// notifyItemInserted(getItemCount());
24+
// }
25+
// }
26+
//
27+
//
28+
// @Override
29+
// public ChatAdapter.ViewHolder onCreateViewHolder(ViewGroup parent, int viewType) {
30+
// final View view = LayoutInflater.from(parent.getContext()).inflate(R.layout.layout_row_chat, parent, false);
31+
// return new ViewHolder(view);
32+
// }
33+
//
34+
// @Override
35+
// public void onBindViewHolder(ChatAdapter.ViewHolder holder, int position) {
36+
// if (chatEntries.get(holder.getAdapterPosition()).isSelf_flag()) {
37+
// holder.tvChatMessageLocal.setVisibility(View.VISIBLE);
38+
// holder.tvChatMessageLocal.setText(chatEntries.get(holder.getAdapterPosition()).getBody());
39+
// holder.tvChatMessageRemote.setVisibility(View.GONE);
40+
//
41+
// } else {
42+
// holder.tvChatMessageRemote.setVisibility(View.VISIBLE);
43+
// holder.tvChatMessageRemote.setText(chatEntries.get(holder.getAdapterPosition()).getBody());
44+
// holder.tvChatMessageLocal.setVisibility(View.GONE);
45+
// }
46+
// }
47+
//
48+
// @Override
49+
// public int getItemCount() {
50+
// return chatEntries.size();
51+
// }
52+
//
53+
// class ViewHolder extends RecyclerView.ViewHolder implements View.OnClickListener {
54+
// private TextView tvChatMessageLocal;
55+
// private TextView tvChatMessageRemote;
56+
//
57+
// ViewHolder(View view) {
58+
// super(view);
59+
// this.tvChatMessageLocal = (TextView) view.findViewById(R.id.tvChatMessageLocal);
60+
// this.tvChatMessageRemote = (TextView) view.findViewById(R.id.tvChatMessageRemote);
61+
// view.setOnClickListener(this);
62+
// }
63+
//
64+
// @Override
65+
// public void onClick(View v) {
66+
//
67+
// }
68+
// }
69+
//}

‎app/src/main/java/com/sidzi/circleofmusic/adapters/PotmAdapter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ public void onResponse(JSONArray response) {
5252
}, new Response.ErrorListener() {
5353
@Override
5454
public void onErrorResponse(VolleyError error) {
55-
55+
// Couldn't fetch data
5656
}
5757
});
5858
requestQueue.add(trackRequest);

‎app/src/main/java/com/sidzi/circleofmusic/adapters/TracksAdapter.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -103,8 +103,8 @@ public int getItemCount() {
103103
}
104104

105105
class ViewHolder extends RecyclerView.ViewHolder implements View.OnClickListener, View.OnLongClickListener {
106-
TextView tnTextView;
107-
TextView tdTextView;
106+
private TextView tnTextView;
107+
private TextView tdTextView;
108108

109109

110110
ViewHolder(View view) {

0 commit comments

Comments
 (0)