music service auto stop on idling + action bar scroll up on swipe up

Author: Sid Zi

app/src/main/java/com/sidzi/circleofmusic/services/MusicPlayerService.java

@@ -7,6 +7,7 @@
 import android.media.AudioManager;
 import android.media.MediaPlayer;
 import android.os.Binder;
+import android.os.Handler;
 import android.os.IBinder;
 import android.support.annotation.Nullable;
 import android.support.v4.content.LocalBroadcastManager;
@@ -30,6 +31,7 @@ public class MusicPlayerService extends Service {
     public static final String ACTION_CLOSE = "com.sidzi.circleofmusic.CLOSE";
     public static Track PLAYING_TRACK = null;
     public static boolean PLAYING_BUCKET;
+    private static boolean PLAYING = false;
     private final IBinder mMIBinder = new MusicBinder();
     public MediaPlayer mMediaPlayer = null;
     private int PLAYING_TRACK_POSITION = -1;
@@ -39,14 +41,10 @@ public class MusicPlayerService extends Service {
     private Context mContext;
     private int songsTillSleep = -1;
 
-    @Override
-    public int onStartCommand(Intent intent, int flags, int startId) {
-        return super.onStartCommand(intent, flags, startId);
-    }
-
     @Override
     public void onCreate() {
         super.onCreate();
+//        This is here because onStart is not called when BIND_AUTO_CREATE is used
         mContext = this;
         localBroadcastManager = LocalBroadcastManager.getInstance(this);
         final OrmHandler ormHandler = OpenHelperManager.getHelper(this, OrmHandler.class);
@@ -62,21 +60,16 @@ public void onCreate() {
 
     @Override
     public boolean onUnbind(Intent intent) {
-//        final Handler mHandler = new Handler();
-//        mHandler.postDelayed(new Runnable() {
-//            @Override
-//            public void run() {
-//                try {
-//                    if (!mMediaPlayer.isPlaying()) {
-//                        stopSelf();
-//                    }
-//                } catch (NullPointerException e) {
-//                    stopSelf();
-//                } finally {
-//                    mHandler.postDelayed(this, 15000);
-//                }
-//            }
-//        }, 15000);
+        final Handler mHandler = new Handler();
+        mHandler.postDelayed(new Runnable() {
+            @Override
+            public void run() {
+                if (!PLAYING)
+                    stopSelf();
+                else
+                    mHandler.postDelayed(this, 15000);
+            }
+        }, 15000);
         return super.onUnbind(intent);
     }
 
@@ -93,6 +86,7 @@ public void onDestroy() {
 
 
     public void play(String track_path) {
+        PLAYING = true;
         if (mMediaPlayer == null)
             init();
         mMediaPlayer.reset();
@@ -119,6 +113,7 @@ public void onCompletion(MediaPlayer mediaPlayer) {
     }
 
     public void play(String Path, String Artist, String Name) {
+        PLAYING = true;
         if (mMediaPlayer == null)
             init();
         mMediaPlayer.reset();
@@ -134,6 +129,8 @@ public void play(String Path, String Artist, String Name) {
     }
 
     public void bucketPlay(String track_path) {
+        PLAYING = true;
+
         if (mMediaPlayer == null)
             init();
         mMediaPlayer.reset();
@@ -173,11 +170,13 @@ public void next(boolean bucket) {
     }
 
     public void pause() {
+        PLAYING = false;
         mMediaPlayer.pause();
         uiUpdate(false);
     }
 
     public void unpause() {
+        PLAYING = true;
         mMediaPlayer.start();
         uiUpdate(false);
     }

app/src/main/java/com/sidzi/circleofmusic/ui/MainActivity.java

@@ -59,6 +59,8 @@
 
 public class MainActivity extends AppCompatActivity {
 
+    ServiceConnection musicServiceConnection;
+
     @Override
     protected void onCreate(Bundle savedInstanceState) {
         super.onCreate(savedInstanceState);
@@ -107,7 +109,7 @@ public void onErrorResponse(VolleyError error) {
             Intent intent = new Intent(getApplicationContext(), MusicPlayerService.class);
             if (MusicPlayerService.PLAYING_TRACK == null)
                 startService(intent);
-            ServiceConnection musicServiceConnection = new ServiceConnection() {
+            musicServiceConnection = new ServiceConnection() {
                 @Override
                 public void onServiceConnected(ComponentName componentName, IBinder iBinder) {
                     MusicPlayerService.MusicBinder musicBinder = (MusicPlayerService.MusicBinder) iBinder;
@@ -121,7 +123,6 @@ public void onServiceConnected(ComponentName componentName, IBinder iBinder) {
                         else
                             LocalBroadcastManager.getInstance(getApplicationContext()).sendBroadcast(new Intent(MusicPlayerService.ACTION_PAUSE));
                     }
-                    unbindService(this);
                 }
 
                 @Override
@@ -232,11 +233,6 @@ public void onServiceDisconnected(ComponentName componentName) {
                         });
                 builder.create().show();
                 break;
-            case R.id.exit:
-                stopService(new Intent(getApplicationContext(), MusicPlayerService.class));
-                LocalBroadcastManager.getInstance(this).sendBroadcast(new Intent(MusicPlayerService.ACTION_CLOSE));
-                finish();
-                break;
             case R.id.register:
                 final AlertDialog.Builder builder1 = new AlertDialog.Builder(this);
                 final EditText etUsername = new EditText(this);
@@ -299,6 +295,7 @@ protected void onDestroy() {
         try {
             BucketSaver bucketSaver = new BucketSaver(this);
             bucketSaver.saveFile();
+            unbindService(musicServiceConnection);
         } catch (IllegalArgumentException | NullPointerException e) {
             e.printStackTrace();
         }

app/src/main/res/layout/activity_main.xml

@@ -21,6 +21,7 @@
             android:layout_width="match_parent"
             android:layout_height="?attr/actionBarSize"
             android:background="?attr/colorPrimary"
+            app:layout_scrollFlags="scroll|enterAlways"
             app:popupTheme="@style/AppTheme.PopupOverlay">
 
             <android.support.v7.widget.SearchView

app/src/main/res/menu/menu_home.xml

@@ -20,8 +20,4 @@
     <item
         android:id="@+id/register"
         android:title="Register/Login" />
-
-    <item
-        android:id="@+id/exit"
-        android:title="Quit" />
 </menu>