Skip to content

Commit 538ba25

Browse files
committed
Upadte README
1 parent 7fb9824 commit 538ba25

File tree

1 file changed

+12
-6
lines changed

1 file changed

+12
-6
lines changed

README.md

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ When I look at the application, it is huge. When the task is huge, you don't kno
103103

104104
I learned a lot of stuff. I know you might also have a curiosity about the process of building the same scale app as well. That's why I am writing a tutorial series on how I built Angular Jira clone from scratch. I hope you guys will learn something from that too :)
105105

106-
Please bear with me for a little longer. Because with almost 50 hours coding, to write every single step is impossible. But hopefully through the tutorial, you will get the idea and can start building your idea very soon.
106+
Because with almost 45 hours coding, to write every single step is impossible. But I will try to be as detail as possible. Hopefully through the tutorial, you will get the idea and can start building your idea very soon. Please bear with me.
107107

108108
Its series will also be published in Vietnamese as part of our [angular-vietnam/100-days-of-angular][100days].
109109

@@ -127,7 +127,7 @@ Its series will also be published in Vietnamese as part of our [angular-vietnam/
127127

128128
## Time spending
129129

130-
I built it as the side project so It usually took longer than expected. One day, my team and I were fire fighting on PROD until 11 PM. After taking a shower, I continue with Angular Jira clone for another two hours...
130+
It is a side project that I only spent time outside of the working hours to working on. One day, my team and I were fire fighting on PROD until 11 PM. After taking a shower, I continue with Angular Jira clone for another two hours...
131131

132132
According to waka time report, I have spent about 45 hours working on this project. Which is equivalent to watch the [whole Stranger Things series twice][stranger].
133133

@@ -147,7 +147,7 @@ I built a very simple NestJS API to send a fixed data structure to the client. A
147147

148148
### Proper authentication system 🔐
149149

150-
I am currently sending a fixed email and a random password to the server to get the current user back. Phase 2 will also bring a proper authentication system.
150+
I am currently sending the same email and a random password to the server without any check to get the current user back. Phase 2 will also bring a proper authentication system.
151151

152152
### Accessibility ♿
153153

@@ -157,15 +157,19 @@ Not all components have properly defined [aria attributes](https://developer.moz
157157

158158
- `git clone https://github.com/trungk18/jira-clone-angular.git`
159159
- `cd jira-clone-angular`
160-
- `npm run install-dependencies`
161160
- `npm run start:back` for the API
161+
- The API server should run on `http://localhost:3000`
162162
- `npm run start:front` for angular web application
163-
- App should now be running on `http://localhost:4200/`
163+
- The app should run on `http://localhost:4200/`
164164

165165
### Unit/Integration tests 🧪
166166

167167
I skipped writing test for this project. I might do it for the proper backend GraphQL API.
168168

169+
## Compatibility
170+
171+
It was being tested on IE 11, Chrome and Firefox. For Safari, there are some minor alignment issues.
172+
169173
## Author: Trung Vo ✍️
170174

171175
- A young and passionate front-end engineer. Working with Angular and TypeScript. Like photography, running, cooking, and reading books.
@@ -180,7 +184,9 @@ If you'd like to contribute, please fork the repository and make changes as you'
180184

181185
## Credits
182186

183-
Inspired by [oldboyxx/jira_clone][oldboyxx] and [Datlyfe/jira_clone][datlyfe]
187+
Inspired by [oldboyxx/jira_clone][oldboyxx] and [Datlyfe/jira_clone][datlyfe].
188+
189+
I reused part of the HTML and CSS code from these projects.
184190

185191
## License
186192

0 commit comments

Comments
 (0)