Skip to content

Commit 1a5d42d

Browse files
committed
Merge branch 'master' of https://github.com/aadityataparia/js-framework-benchmark into aadityataparia-master
2 parents b7d2e0f + 61ae147 commit 1a5d42d

File tree

3 files changed

+17
-20
lines changed

3 files changed

+17
-20
lines changed

frameworks/non-keyed/sifrr/elements/main/element.html

Lines changed: 15 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -68,25 +68,22 @@ <h1>Sifrr</h1>
6868
class MainElement extends Sifrr.Dom.Element {
6969
onConnect() {
7070
const self = this;
71-
this.$('div').$click = (e, target) => {
72-
if (target.matches('.remove')) {
73-
const id = getParent(target).state.id;
74-
// console.log("delete",id);
75-
const data = self.state.data;
76-
for(let i = data.length-1; i >= 0; i--){
77-
if (data[i].id == id) {
78-
data.splice(i, 1);
79-
}
71+
Sifrr.Dom.Event.addListener('click', '.remove', (e, target) => {
72+
const id = getParent(target).state.id;
73+
const data = self.state.data;
74+
for(let i = data.length - 1; i >= 0; i--){
75+
if (data[i].id === id) {
76+
data.splice(i, 1);
8077
}
81-
self.state = { data: data };
82-
} else if (target.matches('.lbl')) {
83-
const el = getParent(target);
84-
// console.log("select", id);
85-
if (self.selected) self.selected.className = '';
86-
el.className = 'danger';
87-
self.selected = el;
8878
}
89-
};
79+
self.state = { data: data };
80+
});
81+
Sifrr.Dom.Event.addListener('click', '.lbl', (e, target) => {
82+
const el = getParent(target);
83+
if (self.selected) self.selected.className = '';
84+
el.className = 'danger';
85+
self.selected = el;
86+
});
9087
}
9188

9289
run() {
@@ -142,7 +139,7 @@ <h1>Sifrr</h1>
142139
if (window.useSifrrInArray) {
143140
MainElement.addArrayToDom('data', '<tr is="sifrr-row"></tr>');
144141
} else {
145-
MainElement.addArrayToDom('data', "<tr><td class='col-md-1 id'>${id}</td><td class='col-md-4'><a class='lbl'>${label}</a></td><td class='col-md-1'><a class='remove'><span class='remove glyphicon glyphicon-remove' aria-hidden='true'></span></a></td><td class='col-md-6'></td></tr>");
142+
MainElement.addArrayToDom('data', "<tr><td class='col-md-1 id'>${id}</td><td class='col-md-4'><a class='lbl'>${label}</a></td><td class='col-md-1'><a class='remove'><span class='glyphicon glyphicon-remove' aria-hidden='true'></span></a></td><td class='col-md-6'></td></tr>");
146143
}
147144
Sifrr.Dom.register(MainElement);
148145
});

frameworks/non-keyed/sifrr/elements/sifrr/row.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<template>
22
<td class='col-md-1'>${this.state.id}</td>
33
<td class='col-md-4'><a class='lbl'>${this.state.label}</a></td>
4-
<td class='col-md-1'><a class='remove'><span class='remove glyphicon glyphicon-remove' aria-hidden='true'></span></a></td>
4+
<td class='col-md-1'><a class='remove'><span class='glyphicon glyphicon-remove' aria-hidden='true'></span></a></td>
55
<td class='col-md-6'></td>
66
</template>
77
<script type="text/javascript">

frameworks/non-keyed/sifrr/index.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
</head>
99

1010
<body>
11-
<main-element></main-element>
11+
<main-element id='main'></main-element>
1212
<script src='dist/app.min.js'></script>
1313
</body>
1414

0 commit comments

Comments
 (0)