Closes sebastianbergmann#664

Author: sebastianbergmann

ChangeLog.md

@@ -2,6 +2,12 @@
 
 All notable changes of the php-code-coverage 6.1 release series are documented in this file using the [Keep a CHANGELOG](http://keepachangelog.com/) principles.
 
+## [7.0.1] - 2019-MM-DD
+
+### Fixed
+
+* Fixed [#664](https://github.com/sebastianbergmann/php-code-coverage/issues/664): `TypeError` when whitelisted file does not exist
+
 ## [7.0.0] - 2019-02-01
 
 ### Added
@@ -48,6 +54,7 @@ All notable changes of the php-code-coverage 6.1 release series are documented i
 * Class names are now abbreviated (unqualified name shown, fully qualified name shown on hover) in the file view of the HTML report
 * Update HTML report to Bootstrap 4
 
+[7.0.1]: https://github.com/sebastianbergmann/php-code-coverage/compare/7.0.0...7.0.1
 [7.0.0]: https://github.com/sebastianbergmann/php-code-coverage/compare/6.1.4...7.0.0
 [6.1.4]: https://github.com/sebastianbergmann/php-code-coverage/compare/6.1.3...6.1.4
 [6.1.3]: https://github.com/sebastianbergmann/php-code-coverage/compare/6.1.2...6.1.3

src/Filter.php

@@ -48,7 +48,13 @@ public function addDirectoryToWhitelist(string $directory, string $suffix = '.ph
      */
     public function addFileToWhitelist(string $filename): void
     {
-        $this->whitelistedFiles[\realpath($filename)] = true;
+        $filename = \realpath($filename);
+
+        if (!$filename) {
+            return;
+        }
+
+        $this->whitelistedFiles[$filename] = true;
     }
 
     /**
@@ -83,6 +89,10 @@ public function removeFileFromWhitelist(string $filename): void
     {
         $filename = \realpath($filename);
 
+        if (!$filename || !isset($this->whitelistedFiles[$filename])) {
+            return;
+        }
+
         unset($this->whitelistedFiles[$filename]);
     }
 

tests/tests/FilterTest.php

@@ -194,4 +194,19 @@ public function testNonFilesAreFiltered(): void
         $this->assertTrue($this->filter->isFiltered('assert code'));
         $this->assertTrue($this->filter->isFiltered('regexp code'));
     }
+
+    /**
+     * @covers SebastianBergmann\CodeCoverage\Filter::addFileToWhitelist
+     * @covers SebastianBergmann\CodeCoverage\Filter::getWhitelist
+     *
+     * @ticket https://github.com/sebastianbergmann/php-code-coverage/issues/664
+     */
+    public function testTryingToAddFileThatDoesNotExistDoesNotChangeFilter(): void
+    {
+        $filter = new Filter;
+
+        $filter->addFileToWhitelist('does_not_exist');
+
+        $this->assertEmpty($filter->getWhitelistedFiles());
+    }
 }