Remove isReplay requirement to turn off Cyan Audit and process actions inside database transaction

Author: Julien Heller

src/MassiveActionHandler.test.ts

@@ -193,31 +193,14 @@ describe('TestMassiveActionHandler', () => {
     actionReader.getLastIrreversibleBlockNumber = jest.fn().mockReturnValue(2)
     const nextBlock = await actionReader.getNextBlock()
     expect(nextBlock.lastIrreversibleBlockNumber).toEqual(2)
-    await actionHandler.handleBlock(nextBlock, true)
+    await actionHandler.handleBlock(nextBlock, false)
 
     const nextBlock2 = await actionReader.getNextBlock()
-    await actionHandler.handleBlock(nextBlock2, true)
+    await actionHandler.handleBlock(nextBlock2, false)
     let result = await massiveInstance.query('select cyanaudit.fn_get_is_enabled();')
     expect(result[0].fn_get_is_enabled).toBe(false)
     expect(actionHandler._getCyanAuditStatus()).toEqual(false)
 
-    const nextBlock3 = await actionReader.getNextBlock()
-    await actionHandler.handleBlock(nextBlock3, true)
-    result = await massiveInstance.query('select cyanaudit.fn_get_is_enabled();')
-    expect(result[0].fn_get_is_enabled).toBe(true)
-    expect(actionHandler._getCyanAuditStatus()).toEqual(true)
-  })
-
-  it('with Cyan Audit on if isReplay is false', async () => {
-    actionReader.getLastIrreversibleBlockNumber = jest.fn().mockReturnValue(2)
-    const nextBlock = await actionReader.getNextBlock()
-    await actionHandler.handleBlock(nextBlock, false)
-    const nextBlock2 = await actionReader.getNextBlock()
-    await actionHandler.handleBlock(nextBlock2, false)
-    let result = await massiveInstance.query('select cyanaudit.fn_get_is_enabled();')
-    expect(result[0].fn_get_is_enabled).toBe(true)
-    expect(actionHandler._getCyanAuditStatus()).toEqual(true)
-
     const nextBlock3 = await actionReader.getNextBlock()
     await actionHandler.handleBlock(nextBlock3, false)
     result = await massiveInstance.query('select cyanaudit.fn_get_is_enabled();')
@@ -229,11 +212,11 @@ describe('TestMassiveActionHandler', () => {
     actionReader.getLastIrreversibleBlockNumber = jest.fn().mockReturnValue(2)
     const nextBlock = await actionReader.getNextBlock()
     expect(nextBlock.lastIrreversibleBlockNumber).toEqual(2)
-    await actionHandler.handleBlock(nextBlock, true)
+    await actionHandler.handleBlock(nextBlock, false)
     const nextBlock2 = await actionReader.getNextBlock()
-    await actionHandler.handleBlock(nextBlock2, true)
+    await actionHandler.handleBlock(nextBlock2, false)
     const nextBlock3 = await actionReader.getNextBlock()
-    await actionHandler.handleBlock(nextBlock3, true)
+    await actionHandler.handleBlock(nextBlock3, false)
     const result = await massiveInstance.query('select cyanaudit.fn_get_is_enabled();')
     expect(result[0].fn_get_is_enabled).toBe(true)
     expect(actionHandler._getCyanAuditStatus()).toEqual(true)

src/MassiveActionHandler.ts

@@ -118,8 +118,8 @@ export class MassiveActionHandler extends AbstractActionHandler {
 
   protected async handleWithState(handle: (state: any, context?: any) => void): Promise<void> {
     const indexState = await this.loadIndexState()
-    const { isReplay, lastIrreversibleBlockNumber, blockNumber } = indexState
-    if (isReplay && blockNumber < lastIrreversibleBlockNumber) {
+    const { lastIrreversibleBlockNumber, blockNumber } = indexState
+    if ( blockNumber < lastIrreversibleBlockNumber) {
       await this.turnOffCyanAudit()
       try {
         const db = this.schemaInstance