Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: open-source-parsers/jsoncpp
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: Binyang2014/jsoncpp
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
  • 3 commits
  • 1 file changed
  • 2 contributors

Commits on May 9, 2018

  1. Bug fix: When use stringWriterBuilder to write a really large double … 

    …value, the program may return an incorrect value if we set the precisionType to decimalPlaces. The root cause for this issue is we not check if we convert double to string successfully (sometime the is buffer will be too small to contain the whole string). For this case, I will use significantDigits type instead, and set the precision to 17.
    @Binyang2014
    Binyang2014 committed May 9, 2018
    Configuration menu
    Copy the full SHA
    be4f185 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2018

  1. Adress review comments

    Binyang Li committed May 11, 2018
    Configuration menu
    Copy the full SHA
    8061666 View commit details
    Browse the repository at this point in the history

  2. fix typo error

    Binyang Li committed May 11, 2018
    Configuration menu
    Copy the full SHA
    e772dd7 View commit details
    Browse the repository at this point in the history
Loading