Fix warning C4703

Author: dmex

phlib/kph.c

@@ -107,7 +107,7 @@ NTSTATUS KphConnect2Ex(
 {
     NTSTATUS status;
     SC_HANDLE scmHandle;
-    SC_HANDLE serviceHandle;
+    SC_HANDLE serviceHandle = NULL;
     BOOLEAN started = FALSE;
     BOOLEAN created = FALSE;
 

phlib/native.c

@@ -3936,9 +3936,9 @@ BOOLEAN NTAPI PhpEnumProcessModulesCallback(
     BOOLEAN cont = FALSE;
     PPH_STRING mappedFileName = NULL;
     PWSTR fullDllNameOriginal;
-    PWSTR fullDllNameBuffer;
+    PWSTR fullDllNameBuffer = NULL;
     PWSTR baseDllNameOriginal;
-    PWSTR baseDllNameBuffer;
+    PWSTR baseDllNameBuffer = NULL;
 
     if (!parameters)
         return TRUE;
@@ -4057,8 +4057,8 @@ BOOLEAN NTAPI PhpEnumProcessModulesCallback(
     }
     else
     {
-        PhFree(fullDllNameBuffer);
-
+        if (fullDllNameBuffer)
+            PhFree(fullDllNameBuffer);
         if (baseDllNameBuffer)
             PhFree(baseDllNameBuffer);
     }
@@ -4298,8 +4298,8 @@ BOOLEAN NTAPI PhpEnumProcessModules32Callback(
     BOOLEAN cont;
     LDR_DATA_TABLE_ENTRY nativeEntry;
     PPH_STRING mappedFileName;
-    PWSTR baseDllNameBuffer;
-    PWSTR fullDllNameBuffer;
+    PWSTR baseDllNameBuffer = NULL;
+    PWSTR fullDllNameBuffer = NULL;
     PH_STRINGREF fullDllName;
     PH_STRINGREF systemRootString;
 
@@ -4451,8 +4451,10 @@ BOOLEAN NTAPI PhpEnumProcessModules32Callback(
     }
     else
     {
-        PhFree(baseDllNameBuffer);
-        PhFree(fullDllNameBuffer);
+        if (baseDllNameBuffer)
+            PhFree(baseDllNameBuffer);
+        if (fullDllNameBuffer)
+            PhFree(fullDllNameBuffer);
     }
 
     return cont;

phlib/symprv.c

@@ -429,8 +429,7 @@ BOOLEAN PhGetLineFromAddress(
 
     if (result)
         fileName = PhCreateString(line.FileName);
-
-    if (!result)
+    else
         return FALSE;
 
     *FileName = fileName;

phlib/treenew.c

@@ -5600,12 +5600,10 @@ VOID PhTnpDrawCell(
             textRect.left += SmallIconWidth + TNP_ICON_RIGHT_PADDING;
         }
 
-        if (needsClip)
+        if (needsClip && oldClipRegion)
         {
             SelectClipRgn(hdc, oldClipRegion);
-
-            if (oldClipRegion)
-                DeleteRgn(oldClipRegion);
+            DeleteRgn(oldClipRegion);
         }
 
         if (textRect.left > textRect.right)