Skip to content

Commit f014e1d

Browse files
committed
Updater: Remove legacy VerQueryValue
1 parent db5fc95 commit f014e1d

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

plugins/Updater/Updater.vcxproj

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -79,37 +79,37 @@
7979
<ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'">
8080
<Link>
8181
<AdditionalDependencies>bcrypt.lib;%(AdditionalDependencies)</AdditionalDependencies>
82-
<DelayLoadDLLs>comctl32.dll;bcrypt.dll;gdi32.dll;shell32.dll;user32.dll;version.dll;%(DelayLoadDLLs)</DelayLoadDLLs>
82+
<DelayLoadDLLs>comctl32.dll;bcrypt.dll;gdi32.dll;shell32.dll;user32.dll;%(DelayLoadDLLs)</DelayLoadDLLs>
8383
</Link>
8484
</ItemDefinitionGroup>
8585
<ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">
8686
<Link>
8787
<AdditionalDependencies>bcrypt.lib;%(AdditionalDependencies)</AdditionalDependencies>
88-
<DelayLoadDLLs>comctl32.dll;bcrypt.dll;gdi32.dll;shell32.dll;user32.dll;version.dll;%(DelayLoadDLLs)</DelayLoadDLLs>
88+
<DelayLoadDLLs>comctl32.dll;bcrypt.dll;gdi32.dll;shell32.dll;user32.dll;%(DelayLoadDLLs)</DelayLoadDLLs>
8989
</Link>
9090
</ItemDefinitionGroup>
9191
<ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Debug|ARM64'">
9292
<Link>
9393
<AdditionalDependencies>bcrypt.lib;%(AdditionalDependencies)</AdditionalDependencies>
94-
<DelayLoadDLLs>comctl32.dll;bcrypt.dll;gdi32.dll;shell32.dll;user32.dll;version.dll;%(DelayLoadDLLs)</DelayLoadDLLs>
94+
<DelayLoadDLLs>comctl32.dll;bcrypt.dll;gdi32.dll;shell32.dll;user32.dll;%(DelayLoadDLLs)</DelayLoadDLLs>
9595
</Link>
9696
</ItemDefinitionGroup>
9797
<ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Release|Win32'">
9898
<Link>
9999
<AdditionalDependencies>bcrypt.lib;%(AdditionalDependencies)</AdditionalDependencies>
100-
<DelayLoadDLLs>comctl32.dll;bcrypt.dll;gdi32.dll;shell32.dll;user32.dll;version.dll;%(DelayLoadDLLs)</DelayLoadDLLs>
100+
<DelayLoadDLLs>comctl32.dll;bcrypt.dll;gdi32.dll;shell32.dll;user32.dll;%(DelayLoadDLLs)</DelayLoadDLLs>
101101
</Link>
102102
</ItemDefinitionGroup>
103103
<ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Release|x64'">
104104
<Link>
105105
<AdditionalDependencies>bcrypt.lib;%(AdditionalDependencies)</AdditionalDependencies>
106-
<DelayLoadDLLs>comctl32.dll;bcrypt.dll;gdi32.dll;shell32.dll;user32.dll;version.dll;%(DelayLoadDLLs)</DelayLoadDLLs>
106+
<DelayLoadDLLs>comctl32.dll;bcrypt.dll;gdi32.dll;shell32.dll;user32.dll;%(DelayLoadDLLs)</DelayLoadDLLs>
107107
</Link>
108108
</ItemDefinitionGroup>
109109
<ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Release|ARM64'">
110110
<Link>
111111
<AdditionalDependencies>bcrypt.lib;%(AdditionalDependencies)</AdditionalDependencies>
112-
<DelayLoadDLLs>comctl32.dll;bcrypt.dll;gdi32.dll;shell32.dll;user32.dll;version.dll;%(DelayLoadDLLs)</DelayLoadDLLs>
112+
<DelayLoadDLLs>comctl32.dll;bcrypt.dll;gdi32.dll;shell32.dll;user32.dll;%(DelayLoadDLLs)</DelayLoadDLLs>
113113
</Link>
114114
</ItemDefinitionGroup>
115115
<ItemGroup>

plugins/Updater/updater.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -230,7 +230,7 @@ PPH_STRING UpdateWindowsString(
230230

231231
if (versionInfo)
232232
{
233-
if (VerQueryValue(versionInfo, L"\\", &rootBlock, &rootBlockLength) && rootBlockLength != 0)
233+
if (PhGetFileVersionInfoValue(versionInfo, L"\\", &rootBlock, &rootBlockLength) && rootBlockLength != 0)
234234
{
235235
PhInitFormatU(&fileVersionFormat[0], HIWORD(rootBlock->dwFileVersionLS));
236236
PhInitFormatC(&fileVersionFormat[1], '.');

0 commit comments

Comments
 (0)