Skip to content

Commit 25ae90f

Browse files
author
jenslody
committed
* autofoo: detect the toolkit used to build wxWidgets and use either gtk2 or gtk3 to avoid crashes because of mixing gtk2 and gtk3 libs.
1 parent 584e862 commit 25ae90f

File tree

6 files changed

+26
-17
lines changed

6 files changed

+26
-17
lines changed

configure.ac

Lines changed: 16 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -145,8 +145,8 @@ AC_SUBST(CXXFLAGS)
145145
AC_SUBST(CFLAGS)
146146
AC_SUBST(LIBS)
147147

148-
WX_GTK2_CFLAGS=
149-
WX_GTK2_LIBS=
148+
WX_GTK_CFLAGS=
149+
WX_GTK_LIBS=
150150
WX_X11_CFLAGS=
151151
WX_X11_LIBS=
152152

@@ -188,7 +188,16 @@ case $WX_BASENAME in
188188
if test "x$BUILD_MOUSESAP_TRUE" = "x" -o \
189189
"x$GTK_NOTEBOOK_TRUE" = "x" ; then
190190
if test "x$HAVE_PKG_CONFIG" = "xyes"; then
191-
PKG_CHECK_MODULES([GTK2], [gtk+-2.0 >= 2.0.0])
191+
case $WX_BASENAME in
192+
*wx_gtk3*)
193+
AC_MSG_NOTICE([gtk3 used])
194+
PKG_CHECK_MODULES([GTK], [gtk+-3.0 >= 3.0.0])
195+
;;
196+
*wx_gtk2*)
197+
AC_MSG_NOTICE([gtk2 used])
198+
PKG_CHECK_MODULES([GTK], [gtk+-2.0 >= 2.0.0])
199+
;;
200+
esac
192201
fi
193202
fi
194203

@@ -226,8 +235,8 @@ case $WX_BASENAME in
226235
CB_HUNSPELL_LIBS="$HUNSPELL_LIBS"
227236
CB_FONTCONFIG_CFLAGS="$FONTCONFIG_CFLAGS"
228237
CB_FONTCONFIG_LIBS="$FONTCONFIG_LIBS"
229-
WX_GTK2_CFLAGS="$GTK2_CFLAGS"
230-
WX_GTK2_LIBS="$GTK2_LIBS"
238+
WX_GTK_CFLAGS="$GTK_CFLAGS"
239+
WX_GTK_LIBS="$GTK_LIBS"
231240
AC_PATH_XTRA
232241
WX_X11_CFLAGS="`echo $X_CFLAGS | sed 's/ -INONE//'`"
233242
WX_X11_LIBS="`echo $X_LIBS | sed 's/ -LNONE//' | sed 's/ -RNONE//'`"
@@ -318,8 +327,8 @@ AC_SUBST(CB_SQUIRREL_CFLAGS)
318327
AC_SUBST(CB_SQUIRREL_LIBS)
319328
AC_SUBST(CB_TINYXML_CFLAGS)
320329
AC_SUBST(CB_TINYXML_LIBS)
321-
AC_SUBST(WX_GTK2_CFLAGS)
322-
AC_SUBST(WX_GTK2_LIBS)
330+
AC_SUBST(WX_GTK_CFLAGS)
331+
AC_SUBST(WX_GTK_LIBS)
323332
AC_SUBST(CB_GLIB2_CFLAGS)
324333
AC_SUBST(CB_GLIB2_LIBS)
325334
AC_SUBST(CB_GAMIN_CFLAGS)

src/plugins/contrib/MouseSap/Makefile.am

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
AM_CPPFLAGS = $(WX_CXXFLAGS) \
2-
$(WX_GTK2_CFLAGS) \
2+
$(WX_GTK_CFLAGS) \
33
-I$(top_srcdir)/src/include \
44
-I$(top_srcdir)/src/sdk/wxscintilla/include
55

@@ -9,7 +9,7 @@ pluginlib_LTLIBRARIES = libMouseSap.la
99

1010
libMouseSap_la_LDFLAGS = -module -version-info 0:1:0 -shared -no-undefined -avoid-version
1111

12-
libMouseSap_la_LIBADD = ../../../sdk/libcodeblocks.la $(WX_LIBS) $(WX_GTK2_LIBS)
12+
libMouseSap_la_LIBADD = ../../../sdk/libcodeblocks.la $(WX_LIBS) $(WX_GTK_LIBS)
1313

1414
libMouseSap_la_SOURCES = MouseSap.cpp
1515

src/plugins/contrib/codesnippets/Makefile.am

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
SUBDIRS = resources
22

33
AM_CPPFLAGS = $(WX_CXXFLAGS) \
4-
$(WX_GTK2_CFLAGS) \
4+
$(WX_GTK_CFLAGS) \
55
$(WX_X11_CFLAGS) \
66
-I$(top_srcdir)/src/include \
77
-I$(top_srcdir)/src/sdk/wxscintilla/include \
@@ -19,7 +19,7 @@ pluginlib_LTLIBRARIES = libcodesnippets.la
1919

2020
libcodesnippets_la_LDFLAGS = -module -version-info 0:1:0 -shared -no-undefined -avoid-version
2121

22-
libcodesnippets_la_LIBADD = ../../../sdk/libcodeblocks.la $(WX_LIBS) $(WX_GTK2_LIBS) $(WX_X11_LIBS)
22+
libcodesnippets_la_LIBADD = ../../../sdk/libcodeblocks.la $(WX_LIBS) $(WX_GTK_LIBS) $(WX_X11_LIBS)
2323

2424
libcodesnippets_la_SOURCES = codesnippets.cpp \
2525
codesnippetstreectrl.cpp \

src/plugins/contrib/codesnippets/resources/Makefile.am

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
AM_CPPFLAGS = $(WX_CXXFLAGS) \
2-
$(WX_GTK2_CFLAGS) \
2+
$(WX_GTK_CFLAGS) \
33
$(WX_X11_CFLAGS)
44

55
pluginlibdir = $(pkglibdir)/plugins
@@ -11,7 +11,7 @@ pluginlibdir = $(pkglibdir)/plugins
1111
##codesnippets_LDADD = $(WX_LIBS) ../../../../sdk/libcodeblocks.la
1212
##codesnippets_LDADD = -L../../../../sdk ../../../../sdk/libcodeblocks.la \
1313
## ../../../../base/tinyxml/libtinyxml.la \
14-
## $(WX_LIBS) $(WX_GTK2_LIBS) $(WX_X11_LIBS)
14+
## $(WX_LIBS) $(WX_GTK_LIBS) $(WX_X11_LIBS)
1515

1616
pkgdata_DATA = codesnippets.zip
1717
CLEANFILES = $(pkgdata_DATA)

src/plugins/debuggergdb/Makefile.am

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ pluginlib_LTLIBRARIES = libdebugger.la
1212

1313
libdebugger_la_LDFLAGS = -module -version-info 0:1:0 -shared -no-undefined -avoid-version
1414

15-
libdebugger_la_LIBADD = ../../sdk/libcodeblocks.la $(WX_LIBS) $(WX_GTK2_LIBS)
15+
libdebugger_la_LIBADD = ../../sdk/libcodeblocks.la $(WX_LIBS) $(WX_GTK_LIBS)
1616

1717
libdebugger_la_SOURCES = cdb_driver.cpp \
1818
databreakpointdlg.cpp \

src/src/Makefile.am

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ GTK_NOTEBOOK_FLAGS = -DUSE_GTK_NOTEBOOK
1818
endif
1919

2020
if CODEBLOCKS_LINUX
21-
AM_CPPFLAGS += -DENABLE_BINRELOC -DAPP_PREFIX="\"@prefix@\"" $(WX_GTK2_CFLAGS) $(GTK_NOTEBOOK_FLAGS)
21+
AM_CPPFLAGS += -DENABLE_BINRELOC -DAPP_PREFIX="\"@prefix@\"" $(WX_GTK_CFLAGS) $(GTK_NOTEBOOK_FLAGS)
2222
endif
2323

2424
bin_PROGRAMS = codeblocks
@@ -30,11 +30,11 @@ install-exec-hook:
3030
$(MACSETFILE) -a C $(DESTDIR)$(bindir)/codeblocks$(EXEEXT)
3131

3232
# wxAUI uses GTK+ libraries on wxGTK
33-
# codeblocks_LDFLAGS = $(WX_GTK2_LIBS)
33+
# codeblocks_LDFLAGS = $(WX_GTK_LIBS)
3434

3535
codeblocks_LDADD = ../sdk/libcodeblocks.la \
3636
$(WX_LIBS) \
37-
$(WX_GTK2_LIBS)
37+
$(WX_GTK_LIBS)
3838

3939
codeblocks_SOURCES = app.cpp \
4040
appglobals.cpp \

0 commit comments

Comments
 (0)