Fixed actions.py

Author: liamrahav

basics/actions.py

@@ -14,10 +14,10 @@
 # Here I make a class that extends cocos' ColorLayer class
 # This type of layer is different because it has a background color! (awesome right?)
 class Actions(ColorLayer):
-    # When I initialize it I need to pass in an RRGB colour value so it can set the ColorLayer's background
+    # When I initialize it I need to pass in an RGBA colour value so it can set the ColorLayer's background
     # I grabbed the Peter River colour (#3498db) from http://flatuicolors.com for this sample
     def __init__(self):
-        super(Actions, self).__init__(52, 52, 152, 219)
+        super(Actions, self).__init__(52, 152, 219, 1000)
 
         # I initialize a sprite using the cocos sprite.Sprite class
         # Change the path below to whatever your sprite image is
@@ -30,8 +30,12 @@ def __init__(self):
         # Check those class functions for info on how to code them!
         self.fade_in()
         self.move_left()
-        self.move_right()
-        self.move_right()
+
+        # It's important to note that placing actions one after another can often lead to issues
+        # For example, if you told the sprite to move left one and then move right twice, it would only move right once
+        # This is because python executes the code so quickly that it doesn't have time to complete the first animations
+        # Using the typical time.sleep from the time builtin doesn't work either, because it stops the entire game
+        # Therefore, actions are best suited for user input, not cutscenes or animations
 
     def fade_in(self):
         # First I make a FadeIn animation object
@@ -48,30 +52,14 @@ def fade_in(self):
         # I don't need to reset the opacity because the FadeIn action does that for me!
         self.sprite.do(fade_action)
 
-    def move_left(self, sleep_time=2):
+    def move_left(self):
         # First I make a MoveBy animation object
         # I set this to move -150 on the X axis, 0 on the Y axis, and to take 2 seconds
         left = MoveBy((-150, 0), 2)
 
         # Finally I make my sprite move left
         self.sprite.do(left)
 
-        # I need to make the program sleep so that it lets this animations finish
-        sleep(sleep_time)
-
-    def move_right(self, sleep_time=2):
-        # If you notice, this method is exactly the same as the move left method, but it moves +150 instead of -150
-
-        # First I make a MoveBy animation object
-        # I set this to move +150 on the X axis, 0 on the Y axis, and to take 2 seconds
-        right = MoveBy((150, 0), 2)
-
-        # And I make my sprite move right (just like in left)
-        self.sprite.do(right)
-
-        # Again I need my program to sleep for the 2 seconds the animation requires
-        sleep(sleep_time)
-
 
 # I initialize the director and run the layer (this is typical for cocos programs)
 director.init()

basics/getting_started.py

@@ -1,7 +1,7 @@
 """
 I chose these import statements just to make my close look cleaner
 For this to work you would just need to import cocos and then add the subdirectory after
-Ex: self.label = Label(...) would be self.sprite = cocos.text.Label(...)
+Ex: self.label = Label(...) would be self.label = cocos.text.Label(...)
 """
 import cocos
 from cocos.text import Label
@@ -51,4 +51,4 @@ def __init__(self):
     )
 )
 
-# That's it! Run it and see what happens
+# That's it! Run it and see what happens

basics/review.py

@@ -50,27 +50,32 @@ def __init__(self):
         # We don't need anything else here, let's just let our sprite be moved in the event handlers
 
     # So now we can overload some default event handlers
+    # We'll let the user move in any direction on the screen with the arrow keys, and jump around with the spacebar
     # We'll only be doing keyboard input for this program
     def on_key_press(self, key, modifiers):
         # If you don't know what these next couple lines do, go check the previous tutorials
         move_left = MoveBy((-50, 0), .5)
         move_up = MoveBy((0, 50), .5)
+        jump = Jump(50, 0, 1, .25)
 
         # Check if they want to go left, and then actually make the sprite go left
         if symbol_string(key) == "LEFT":
             self.sprite.do(move_left)
 
         # Or maybe if they want to move right?
-        if symbol_string(key) == "RIGHT":
+        elif symbol_string(key) == "RIGHT":
             self.sprite.do(Reverse(move_left))
 
         # And lastly we need that jump game to be strong
-        if symbol_string(key) == "UP":
+        elif symbol_string(key) == "UP":
             self.sprite.do(move_up)
 
-        if symbol_string(key) == "DOWN":
+        elif symbol_string(key) == "DOWN":
             self.sprite.do(Reverse(move_up))
 
+        elif symbol_string(key) == "SPACE":
+            self.sprite.do(jump)
+
 
 # And finally we do our usual initialization and run the scene
 mixer.init()