Cache and reuse previously computed value

Dmitry-Me · danmar · commit 6482fefe3ea7 · 2014-11-30T13:00:27.000+01:00
diff --git a/lib/symboldatabase.cpp b/lib/symboldatabase.cpp
@@ -1226,8 +1226,9 @@ bool SymbolDatabase::isFunction(const Token *tok, const Scope* outerScope, const
         tok->link()->previous()->str() == ")") {
         const Token* tok2 = tok->link()->next();
         if (tok2 && tok2->str() == "(" && Token::Match(tok2->link()->next(), "{|;|const|=")) {
-            *funcStart = tok->link()->previous()->link()->previous();
-            *argStart = tok->link()->previous()->link();
+            const Token* argStartTok = tok->link()->previous()->link();
+            *funcStart = argStartTok->previous();
+            *argStart = argStartTok;
             return true;
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -1226,8 +1226,9 @@ bool SymbolDatabase::isFunction(const Token tok, const Scope outerScope, const`
`1226`	`1226`	`tok->link()->previous()->str() == ")") {`
`1227`	`1227`	`const Token* tok2 = tok->link()->next();`
`1228`	`1228`	`if (tok2 && tok2->str() == "(" && Token::Match(tok2->link()->next(), "{\|;\|const\|=")) {`
`1229`		`- *funcStart = tok->link()->previous()->link()->previous();`
`1230`		`- *argStart = tok->link()->previous()->link();`
	`1229`	`+ const Token* argStartTok = tok->link()->previous()->link();`
	`1230`	`+ *funcStart = argStartTok->previous();`
	`1231`	`+ *argStart = argStartTok;`
`1231`	`1232`	`return true;`
`1232`	`1233`	`}`
`1233`	`1234`	`}`