Skip to content

Commit 130afd4

Browse files
committed
tests: don't use extractType() here
1 parent b82c32f commit 130afd4

File tree

2 files changed

+8
-8
lines changed
  • plugins/org.eclipse.dltk.javascript.core/src/org/eclipse/dltk/javascript/typeinfo
  • tests/org.eclipse.dltk.javascript.core.tests/src/org/eclipse/dltk/javascript/core/tests/typeinference

2 files changed

+8
-8
lines changed

plugins/org.eclipse.dltk.javascript.core/src/org/eclipse/dltk/javascript/typeinfo/TypeUtil.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -106,6 +106,7 @@ public static ParameterizedType genericType(String baseType,
106106
return genericType;
107107
}
108108

109+
@Deprecated
109110
public static Type extractType(JSType type) {
110111
if (type instanceof SimpleType) {
111112
return ((SimpleType) type).getTarget();

tests/org.eclipse.dltk.javascript.core.tests/src/org/eclipse/dltk/javascript/core/tests/typeinference/TypeInferenceTests.java

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@
3333
import org.eclipse.dltk.javascript.typeinference.IValueReference;
3434
import org.eclipse.dltk.javascript.typeinfo.IRClassType;
3535
import org.eclipse.dltk.javascript.typeinfo.IRRecordType;
36+
import org.eclipse.dltk.javascript.typeinfo.IRSimpleType;
3637
import org.eclipse.dltk.javascript.typeinfo.IRType;
3738
import org.eclipse.dltk.javascript.typeinfo.ITypeNames;
3839
import org.eclipse.dltk.javascript.typeinfo.JSTypeSet;
@@ -79,10 +80,6 @@ private IValueCollection inference(final String code) {
7980
return inferencer.getCollection();
8081
}
8182

82-
private Type extractType(IRType type) {
83-
return TypeUtil.extractType(inferencer, type);
84-
}
85-
8683
public void testNewNamedFunction() throws Exception {
8784
List<String> lines = new StringList();
8885
lines.add("var test = new function Test() {");
@@ -711,7 +708,8 @@ public void testJavaClzIntegrationWithPackagesPrefix() {
711708

712709
IValueReference str = collection.getChild("x");
713710
assertEquals(1, str.getTypes().size());
714-
assertEquals(stringType, extractType(str.getTypes().getFirst()));
711+
assertEquals(stringType,
712+
((IRSimpleType) str.getTypes().toRType()).getTarget());
715713

716714
final Member toString = stringType.findDirectMember("toString");
717715
assertNotNull(toString);
@@ -735,7 +733,8 @@ public void testJavaClzIntegrationWithJavaPrefix() {
735733

736734
IValueReference str = collection.getChild("x");
737735
assertEquals(1, str.getTypes().size());
738-
assertEquals(stringType, extractType(str.getTypes().getFirst()));
736+
assertEquals(stringType,
737+
((IRSimpleType) str.getTypes().toRType()).getTarget());
739738

740739
final Member toString = stringType.findDirectMember("toString");
741740
assertNotNull(toString);
@@ -752,7 +751,7 @@ public void testJavaIntegrationWithJavaPrefix() {
752751
assertEquals("java.lang.String", type.getName());
753752

754753
boolean toStringFound = false;
755-
for (Member member : extractType(type).getMembers()) {
754+
for (Member member : ((IRSimpleType) type).getTarget().getMembers()) {
756755
toStringFound = member.getName().equals("toString");
757756
if (toStringFound) {
758757
assertEquals(false, member.isStatic());
@@ -774,7 +773,7 @@ public void testJavaIntegrationWithPackagesPrefix() {
774773
assertEquals("java.lang.String", type.getName());
775774

776775
boolean toStringFound = false;
777-
for (Member member : extractType(type).getMembers()) {
776+
for (Member member : ((IRSimpleType) type).getTarget().getMembers()) {
778777
toStringFound = member.getName().equals("toString");
779778
if (toStringFound) {
780779
assertEquals(false, member.isStatic());

0 commit comments

Comments
 (0)