Bug#25495393: GROUP REPLICATION CAN USE SOME VERBOSITY IN THE ERROR LOG

Post push handled windows build issues and doxygen warnings.

Author: Jaideep Karande

rapid/plugin/group_replication/include/gcs_event_handlers.h

@@ -270,14 +270,14 @@ class Plugin_gcs_events_handler: public Gcs_communication_event_listener,
   /**
     Logs member joining message to error logs from view.
 
-    @param[in]  view        the view delivered by the GCS
+    @param[in]  new_view        the view delivered by the GCS
   */
   void log_members_joining_message(const Gcs_view& new_view) const;
 
   /**
     Logs member leaving message to error logs from view.
 
-    @param[in]  view        the view delivered by the GCS
+    @param[in]  new_view        the view delivered by the GCS
   */
   void log_members_leaving_message(const Gcs_view& new_view) const;
 
@@ -286,9 +286,9 @@ class Plugin_gcs_events_handler: public Gcs_communication_event_listener,
     in HOST:PORT format separated by comma.
     Function also return PRIMARY member if any in HOST:PORT format.
 
-    @param[in]    joining/leaving members for this view
-    @param[out]   host and port of all members from view
-    @param[out]   primary member hosts and port of all members from view
+    @param[in]    members      joining or leaving members for this view
+    @param[out]   all_hosts    host and port of all members from view
+    @param[out]   primary_host primary member hosts and port of all members from view
   */
   void get_hosts_from_view(const std::vector<Gcs_member_identifier> &members,
                            std::string& all_hosts, std::string& primary_host) const;

rapid/plugin/group_replication/src/gcs_event_handlers.cc

@@ -423,7 +423,7 @@ Plugin_gcs_events_handler::get_hosts_from_view(const std::vector<Gcs_member_iden
     if (member_info->in_primary_mode() &&
         member_info->get_role() == Group_member_info::MEMBER_ROLE_PRIMARY)
     {
-      if (primary_string.tellp() != 0)
+      if (primary_string.rdbuf()->in_avail() != 0)
         primary_string << ", ";
       primary_string << member_info->get_hostname() << ":" << member_info->get_port();
     }