replace old redirect method with new RedirectStrategy (android-async-http#1335)

Author: saeed-rz

library/src/main/java/com/loopj/android/http/AsyncHttpClient.java

@@ -310,10 +310,7 @@ public RequestHandle delete(Context context, String url, Header[] headers, Reque
      * @deprecated
      */
     public void setEnableRedirects(final boolean enableRedirects, final boolean enableRelativeRedirects, final boolean enableCircularRedirects) throws IllegalAccessException {
-        if (getHttpClientProvider() instanceof DefaultHttpClientProvider) {
-            ((DefaultHttpClientProvider) getHttpClientProvider()).setEnableRedirects(enableRedirects, enableRelativeRedirects, enableCircularRedirects);
-        }
-        throw new IllegalAccessException("This method shall not be used with non-default credentials provider set");
+        setEnableRedirectStrategy(enableRedirects);
     }
 
     /**
@@ -325,7 +322,7 @@ public void setEnableRedirects(final boolean enableRedirects, final boolean enab
      * @deprecated
      */
     public void setEnableRedirects(final boolean enableRedirects, final boolean enableRelativeRedirects) throws IllegalAccessException {
-        setEnableRedirects(enableRedirects, enableRelativeRedirects, true);
+        setEnableRedirectStrategy(enableRedirects);
     }
 
     /**
@@ -334,7 +331,7 @@ public void setEnableRedirects(final boolean enableRedirects, final boolean enab
      * @deprecated
      */
     public void setEnableRedirects(final boolean enableRedirects) throws IllegalAccessException {
-        setEnableRedirects(enableRedirects, enableRedirects, enableRedirects);
+        setEnableRedirectStrategy(enableRedirects);
     }
 
     /**
@@ -358,6 +355,18 @@ public void setCookieStore(CookieStore cookieStore) {
     public void setRedirectStrategy(RedirectStrategy redirectStrategy){
         if (getHttpClientProvider() instanceof DefaultHttpClientProvider) {
             ((DefaultHttpClientProvider) getHttpClientProvider()).setRedirectStrategy(redirectStrategy);
+            setEnableRedirectStrategy(true);
+        }
+    }
+
+    /**
+     * Sets enable to use {@link RedirectStrategy} when making requests
+     *
+     * @param isEnable
+     */
+    public void setEnableRedirectStrategy(boolean isEnable){
+        if (getHttpClientProvider() instanceof DefaultHttpClientProvider) {
+            ((DefaultHttpClientProvider) getHttpClientProvider()).setEnableRedirectStrategy(isEnable);
         }
     }
 

library/src/main/java/com/loopj/android/http/DefaultHttpClientProvider.java

@@ -43,6 +43,7 @@ public class DefaultHttpClientProvider implements HttpClientProviderInterface {
     protected HttpRequestRetryHandler retryHandler;
     protected boolean enableRedirects = false, enableRelativeRedirects = false, enableCircularRedirects = false;
     protected RedirectStrategy redirectStrategy;
+    protected boolean enableRedirectStrategy = false;
 
     public DefaultHttpClientProvider() {
     }
@@ -76,8 +77,8 @@ public final CloseableHttpClient provide() {
                 .setDefaultCookieStore(getCookieStore())
                 .setRedirectStrategy(getRedirectStrategy());
 
-        RequestConfig requestConfig = RequestConfig.custom().setCircularRedirectsAllowed(enableCircularRedirects).setRelativeRedirectsAllowed(enableRelativeRedirects).setRedirectsEnabled(enableRedirects).build();
-        builder.setDefaultRequestConfig(requestConfig);
+        if(!enableRedirectStrategy)
+            builder.disableRedirectHandling();
 
         return builder.build();
     }
@@ -115,10 +116,21 @@ public CredentialsProvider getCredentialsProvider() {
     }
 
     public RedirectStrategy getRedirectStrategy() {
-        return redirectStrategy;
+        if(enableRedirectStrategy)
+            return redirectStrategy;
+
+        return null;
     }
 
     public void setRedirectStrategy(RedirectStrategy redirectStrategy) {
         this.redirectStrategy = redirectStrategy;
     }
+
+    public boolean isEnableRedirectStrategy() {
+        return enableRedirectStrategy;
+    }
+
+    public void setEnableRedirectStrategy(boolean enableRedirectStrategy) {
+        this.enableRedirectStrategy = enableRedirectStrategy;
+    }
 }