commit

Author: naldin

README.md

@@ -1,2 +1,10 @@
-# ArduinoServoDCMotor
+## ArduinoServoDCMotor
 An Arduino servo motor with DC motor and potentiometer.
+
+#Servo_DC_Motor_Pot
+Using only proportionality for read/target value.
+
+#Servo_DC_Motor_Pot_Prop
+Using proportionality for read/target value and pwm.
+
+Video [https://www.youtube.com/watch?v=m6xne2mSTUo](https://www.youtube.com/watch?v=m6xne2mSTUo)

Servo_DC_Motor_Pot/Servo_DC_Motor_Pot.ino

@@ -1,24 +1,24 @@
 /*
-    Arduino Servo DC Motor
+    Arduino Servo DC Motor v1.0
     Ronaldo Rezende Junior
     ronaldo.rrj at gmail
     09/2017
     https://github.com/naldin
 */
 
 //variables
-short int valPot = 0;
+short int valRead = 0;
 short int motorPWM = 20; //amount of power motor (0-255) were 255 is max.
 
 //constants
 const short int wireMT_1 = 5; //for wire motor H bridge
 const short int wireMT_2 = 6; //for wire motor H bridge
 const short int potMT = A0; //motor potentiometer
 const short int potIn = A3; //input potentiometer
-const short int diff_error = 20; //max error to potentiometer motor
-const short int minPot = 10;  //minimal input value
-const short int maxPot = 1010; //max input value
-const short int maxValIn = 999; //max *potentiometer value
+const short int diff_error = 10; //max error to potentiometer motor
+const short int minPot = 10;  //minimal position potentiometer motor (0-1023)
+const short int maxPot = 1010; //max position potentiometer motor (0-1023)
+const short int maxValIn = 1023; //max *input value. For this case 1023, the max of pot.
 // *here can use something like degress, where max could be 180
 
 //setup
@@ -29,23 +29,22 @@ void setup() {
   pinMode (potIn, INPUT); //input potentiometer
   digitalWrite (wireMT_1, LOW);
   digitalWrite (wireMT_2, LOW);
-  valPot = analogRead(potMT);
 }
 
 //run motor function
-void runMotor(short int valIn) {
+void runMotor(short int valTarget) {
   //proportionality between input and output value
-  while (valPot <= valIn && abs(valPot - valIn) >  diff_error) {
-    valPot = (((float)analogRead(potMT) - minPot) / (maxPot - minPot)) * maxValIn;
+  while (valRead <= valTarget && abs(valRead - valTarget) >  diff_error) {
+    valRead = (((float)analogRead(potMT) - minPot) / (maxPot - minPot)) * maxValIn;
     //run motor
     analogWrite (wireMT_1, motorPWM);
     analogWrite (wireMT_2, 0);
   }
   analogWrite (wireMT_1, 0); //turn off motor
 
   //proportionality between input and output value
-  while (valPot >= valIn && abs(valPot - valIn) >  diff_error) {
-    valPot = (((float)analogRead(potMT) - minPot) / (maxPot - minPot)) * maxValIn;
+  while (valRead >= valTarget && abs(valRead - valTarget) >  diff_error) {
+    valRead = (((float)analogRead(potMT) - minPot) / (maxPot - minPot)) * maxValIn;
     //run motor
     analogWrite (wireMT_2, motorPWM);
     analogWrite (wireMT_1, 0);

Servo_DC_Motor_Pot_Prop/Servo_DC_Motor_Pot_Prop.ino

@@ -1,5 +1,5 @@
 /*
-    Arduino Servo DC Motor
+    Arduino Servo DC Motor v1.0
     PWM proportional
     Ronaldo Rezende Junior
     ronaldo.rrj at gmail
@@ -8,7 +8,7 @@
 */
 
 //variables
-short int valPot = 0;
+short int valRead = 0;
 short int motorPWM = 0;
 short int error = 0; //difference between target value and input value
 
@@ -19,10 +19,10 @@ const short int wireMT_1 = 5; //for wire motor H bridge
 const short int wireMT_2 = 6; //for wire motor H bridge
 const short int potMT = A0; //motor potentiometer
 const short int potIn = A3; //input potentiometer
-const short int diff_error = 20; //max error to potentiometer motor
+const short int diff_error = 10; //max error to potentiometer motor
 const short int minPot = 10;  //minimal input value
 const short int maxPot = 1010; //max input value
-const short int maxValIn = 999; //max *potentiometer value
+const short int maxValIn = 1023; //max *input value. For this case 1023, the max of pot.
 // *here can use something like degress, where max could be 180
 
 //setup
@@ -33,16 +33,15 @@ void setup() {
   pinMode (potIn, INPUT); //input potentiometer
   digitalWrite (wireMT_1, LOW);
   digitalWrite (wireMT_2, LOW);
-  valPot = analogRead(potMT);
 }
 
 //run motor function
-void runMotor(short int valIn) {
+void runMotor(short int valTarget) {
   //proportionality between input and output value
-  while (valPot <= valIn && abs(valPot - valIn) >  diff_error) {
-    valPot = (((float)analogRead(potMT) - minPot) / (maxPot - minPot)) * maxValIn;
+  while (valRead <= valTarget && abs(valRead - valTarget) >  diff_error) {
+    valRead = (((float)analogRead(potMT) - minPot) / (maxPot - minPot)) * maxValIn;
     //pwm proportional
-    error = valIn - valPot;
+    error = valTarget - valRead;
     motorPWM = ((kp * error) / 100) + mp;
     //run motor
     analogWrite (wireMT_1, motorPWM);
@@ -51,10 +50,10 @@ void runMotor(short int valIn) {
   analogWrite (wireMT_1, 0); //turn off motor
 
   //proportionality between input and output value
-  while (valPot >= valIn && abs(valPot - valIn) >  diff_error) {
-    valPot = (((float)analogRead(potMT) - minPot) / (maxPot - minPot)) * maxValIn;
+  while (valRead >= valTarget && abs(valRead - valTarget) >  diff_error) {
+    valRead = (((float)analogRead(potMT) - minPot) / (maxPot - minPot)) * maxValIn;
     //pwm proportional
-    error = valPot - valIn;
+    error = valRead - valTarget;
     motorPWM = ((kp * error) / 100) + mp;
     //run motor
     analogWrite (wireMT_2, motorPWM);