Skip to content

trade screen should use appraisal skill of the unit trading, not that of the "broker" #5402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ab9rf opened this issue Apr 16, 2025 · 2 comments

Comments

@ab9rf
Copy link
Member

ab9rf commented Apr 16, 2025

in determining how accurate to display values, the screen should use the appraisal skill of whoever is conducting the trade rather than defaulting to the broker

this gives more reasonable results when the "anyone can trade" option has been selected

@myk002
Copy link
Member

myk002 commented Apr 18, 2025

Doesn't what we do match what is displayed in the vanilla UI, though?

@ab9rf
Copy link
Member Author

ab9rf commented Apr 18, 2025

i honestly don't know. the accuracy display is in the viewscreen code, not the caravan handling code, and i don't remember if we even looked into that. we definitely figured out how to determine the raw value, but the accuracy display i don't remember how we decided which unit to use, nor do i recall what the game itself does

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants