Skip to content

suspendmanager UI overlaps workshops when following builder #5439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tatoyoda600 opened this issue May 3, 2025 · 1 comment
Open

suspendmanager UI overlaps workshops when following builder #5439

tatoyoda600 opened this issue May 3, 2025 · 1 comment

Comments

@tatoyoda600
Copy link
Contributor

When following a unit that's scheduled to construct a building using the vanilla DF follow feature, the suspendmanager UI for the unit's job will always render on top of other UIs (workshops, buildings, etc.).

In the following screenshots you'll see me following a dwarf of mine that was assigned to build a door, and the suspendmanager UI for that construction job overlaps other UIs that it shouldn't.

Image

Image

Image

Image

@tatoyoda600
Copy link
Contributor Author

tatoyoda600 commented May 3, 2025

In the suspendmanager.lua code, it appears to use dfhack.gui.getSelectedJob(true) to determine whether to render the overlay widget or not, however that functions seems to return the same job whether you select the building to be constructed, or the unit that's scheduled to construct it.

You normally can't select a unit and some other building's UI for that to be an issue, but when following a unit it's considered selected for dfhack.gui.getSelectedJob(true), despite the fact that you could be actually looking at a different UI. In fact following seems to takes priority over actually selecting, since if I select a different building that's being constructed, I still get the suspendmanager overlay for the dwarf I'm following.

I assume this is probably the cause of the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant