Use protected accessibility instead of private to allow extension

Author: Boy Baukema

src/OneLogin/Saml/AuthRequest.php

@@ -11,7 +11,7 @@ class OneLogin_Saml_AuthRequest
      * A SamlResponse class provided to the constructor.
      * @var OneLogin_Saml_Settings
      */
-    private $_settings;
+    protected $_settings;
 
     /**
      * Construct the response object.
@@ -61,12 +61,12 @@ public function getRedirectUrl()
         return $this->_settings->idpSingleSignOnUrl . "?SAMLRequest=" . $encodedRequest;
     }
 
-    private function _generateUniqueID()
+    protected function _generateUniqueID()
     {
         return self::ID_PREFIX . sha1(uniqid(mt_rand(), TRUE));
     }
 
-    private function _getTimestamp()
+    protected function _getTimestamp()
     {
         $defaultTimezone = date_default_timezone_get();
         date_default_timezone_set('UTC');

src/OneLogin/Saml/Metadata.php

@@ -14,7 +14,7 @@ class OneLogin_Saml_Metadata
      * Service settings
      * @var OneLogin_Saml_Settings
      */
-    private $_settings;
+    protected $_settings;
 
     /**
      * Create a new Metadata document
@@ -47,7 +47,7 @@ public function getXml()
 METADATA_TEMPLATE;
     }
 
-    private function _getMetadataValidTimestamp()
+    protected function _getMetadataValidTimestamp()
     {
         $timeZone = date_default_timezone_get();
         date_default_timezone_set('UTC');

src/OneLogin/Saml/Response.php

@@ -8,7 +8,7 @@ class OneLogin_Saml_Response
     /**
      * @var OneLogin_Saml_Settings
      */
-    private $_settings;
+    protected $_settings;
 
     /**
      * The decoded, unprocessed XML assertion provided to the constructor.
@@ -82,7 +82,7 @@ public function getAttributes()
      * @param string $assertionXpath
      * @return DOMNodeList
      */
-    private function _queryAssertion($assertionXpath)
+    protected function _queryAssertion($assertionXpath)
     {
         $xpath = new DOMXPath($this->document);
         $xpath->registerNamespace('samlp'   , 'urn:oasis:names:tc:SAML:2.0:protocol');

src/OneLogin/Saml/XmlSec.php

@@ -9,13 +9,13 @@ class OneLogin_Saml_XmlSec
      * A SamlResponse class provided to the constructor.
      * @var OneLogin_Saml_Settings
      */
-    private $_settings;
+    protected $_settings;
 
     /**
      * The document to be tested.
      * @var DomDocument
      */
-    private $_document;
+    protected $_document;
 
     /**
      * Construct the SamlXmlSec object.