Merge pull request ProgrammingBlockchain#142 from yahiheb/errors-updates

Fix some errors and update some code

Author: nopara73

bitcoin_transfer/bitcoin_address.md

@@ -41,8 +41,8 @@ Console.WriteLine(publicKey.GetAddress(ScriptPubKeyType.Legacy, Network.TestNet)
 ```cs 
 var publicKeyHash = publicKey.Hash;
 Console.WriteLine(publicKeyHash); // f6889b21b5540353a29ed18c45ea0031280c42cf
-var mainNetAddress = publicKeyHash.GetAddress(ScriptPubKeyType.Legacy, Network.Main);
-var testNetAddress = publicKeyHash.GetAddress(ScriptPubKeyType.Legacy, Network.TestNet);
+var mainNetAddress = publicKeyHash.GetAddress(Network.Main);
+var testNetAddress = publicKeyHash.GetAddress(Network.TestNet);
 ```  
 
 > **Fact:** A public key hash is generated by using a SHA256 hash on the public key, then a RIPEMD160 hash on the result, using Big Endian notation. The function could look like this: RIPEMD160(SHA256(pubkey))  

bitcoin_transfer/payment_script.md

@@ -14,8 +14,8 @@ We are able to generate the ScriptPubKey from the Bitcoin Address. This is a ste
 ```cs 
 var publicKeyHash = new KeyId("14836dbe7f38c5ac3d49e8d790af808a4ee9edcf");
 
-var testNetAddress = publicKeyHash.GetAddress(ScriptPubKeyType.Legacy, Network.TestNet);
-var mainNetAddress = publicKeyHash.GetAddress(ScriptPubKeyType.Legacy, Network.Main);
+var testNetAddress = publicKeyHash.GetAddress(Network.TestNet);
+var mainNetAddress = publicKeyHash.GetAddress(Network.Main);
 
 Console.WriteLine(mainNetAddress.ScriptPubKey); // OP_DUP OP_HASH160 14836dbe7f38c5ac3d49e8d790af808a4ee9edcf OP_EQUALVERIFY OP_CHECKSIG
 Console.WriteLine(testNetAddress.ScriptPubKey); // OP_DUP OP_HASH160 14836dbe7f38c5ac3d49e8d790af808a4ee9edcf OP_EQUALVERIFY OP_CHECKSIG

bitcoin_transfer/private_key.md

@@ -6,8 +6,8 @@ Private keys are often represented in Base58Check called a **Bitcoin Secret** (a
 
 ```cs  
 Key privateKey = new Key(); // generate a random private key
-BitcoinSecret mainNetPrivateKey = privateKey.GetBitcoinSecret(ScriptPubKeyType.Legacy, Network.Main);  // generate our Bitcoin secret(also known as Wallet Import Format or simply WIF) from our private key for the mainnet
-BitcoinSecret testNetPrivateKey = privateKey.GetBitcoinSecret(ScriptPubKeyType.Legacy, Network.TestNet);  // generate our Bitcoin secret(also known as Wallet Import Format or simply WIF) from our private key for the testnet
+BitcoinSecret mainNetPrivateKey = privateKey.GetBitcoinSecret(Network.Main);  // generate our Bitcoin secret(also known as Wallet Import Format or simply WIF) from our private key for the mainnet
+BitcoinSecret testNetPrivateKey = privateKey.GetBitcoinSecret(Network.TestNet);  // generate our Bitcoin secret(also known as Wallet Import Format or simply WIF) from our private key for the testnet
 Console.WriteLine(mainNetPrivateKey); // L5B67zvrndS5c71EjkrTJZ99UaoVbMUAK58GKdQUfYCpAa6jypvn
 Console.WriteLine(testNetPrivateKey); // cVY5auviDh8LmYUW8AfafseD6p6uFoZrP7GjS3rzAerpRKE9Wmuz
 

key_generation/bip_32.md

@@ -76,10 +76,10 @@ masterKey = new ExtKey();
 masterPubKey = masterKey.Neuter();
 
 //The payment server generate pubkey1
-ExtPubKey pubkey1 = masterPubKey.Derive((uint)1);
+ExtPubKey pubkey1 = masterPubKey.Derive(1);
 
 //You get the private key of pubkey1
-ExtKey key1 = masterKey.Derive((uint)1);
+ExtKey key1 = masterKey.Derive(1);
 
 //Check it is legit
 Console.WriteLine("Generated address : " + pubkey1.PubKey.GetAddress(ScriptPubKeyType.Legacy, Network.Main));

other_types_of_asset/issuing_an_asset.md

@@ -54,7 +54,7 @@ var tx = builder
     .AddCoins(issuance)
     .IssueAsset(nico, new AssetMoney(issuance.AssetId, quantity: 10))
     .SendFees(Money.Coins(0.0001m))
-    .SetChange(bookKey.GetAddress())
+    .SetChange(bookKey.GetAddress(ScriptPubKeyType.Legacy))
     .BuildTransaction(true);
 
 Console.WriteLine(tx);

other_types_of_ownership/arbitrary.md

@@ -15,7 +15,7 @@ So first, let’s build the **RedeemScript**,
 ```cs
 BitcoinAddress address = BitcoinAddress.Create("1KF8kUVHK42XzgcmJF4Lxz4wcL5WDL97PB", Network.Main);
 var birth = Encoding.UTF8.GetBytes("18/07/1988");
-var birthHash = Hashes.Hash256(birth);
+var birthHash = Hashes.DoubleSHA256(birth);
 Script redeemScript = new Script(
     "OP_IF "
         + "OP_HASH256 " + Op.GetPushOp(birthHash.ToBytes()) + " OP_EQUAL " +