fix spotDL#1414 (spotDL#1435)

Author: xnetcat

spotdl/download/downloader.py

@@ -163,8 +163,6 @@ async def download_song(self, song_object: SongObject) -> None:
                     song_object, self.arguments["output_format"]
                 )
 
-            converted_file_path.parent.mkdir(parents=True, exist_ok=True)
-
             # if a song is already downloaded skip it
             if converted_file_path.is_file():
                 if self.display_manager:
@@ -176,6 +174,8 @@ async def download_song(self, song_object: SongObject) -> None:
                 # ! it here as a continent way to avoid executing the rest of the function.
                 return None
 
+            converted_file_path.parent.mkdir(parents=True, exist_ok=True)
+
             if self.arguments["output_format"] == "m4a":
                 ytdl_format = "bestaudio[ext=m4a]/bestaudio/best"
             elif self.arguments["output_format"] == "opus":
@@ -199,7 +199,7 @@ async def download_song(self, song_object: SongObject) -> None:
 
             try:
                 downloaded_file_path_string = await self._perform_audio_download_async(
-                    converted_file_path.name.split(".")[0],
+                    converted_file_path.name.rsplit(".", 1)[0],
                     temp_folder,
                     audio_handler,
                     song_object.youtube_link,

spotdl/providers/provider_utils.py

@@ -1,3 +1,5 @@
+import re
+
 from pathlib import Path
 from typing import List
 
@@ -146,4 +148,15 @@ def _parse_path_template(path_template, song_object, output_format, short=False)
 
     converted_file_path = Path(converted_file_name)
 
+    santitized_parts = []
+    for part in converted_file_path.parts:
+        match = re.search(r"[^\.*](.*)[^\.*$]", part)
+        if match:
+            santitized_parts.append(match.group(0))
+        else:
+            santitized_parts.append(part)
+
+    # Join the parts of the path
+    converted_file_path = Path(*santitized_parts)
+
     return converted_file_path