bugfix: replaced youtube-dl with yt-dlp (spotDL#1374)

* bugfix: removed wrong (and unused) exception

* bugfix: replaced yt-dl with yt-dlp

misc: regenerate cassettes

misc: regenerate cassettes again

Author: xnetcat

setup.cfg

@@ -28,13 +28,13 @@ classifiers =
 [options]
 include_package_data = true
 install_requires =
-    spotipy
-    pytube
+    spotipy >= 2.19.0
+    pytube >= 11.0.0
     rich
     rapidfuzz
     mutagen
     ytmusicapi
-    youtube_dl
+    yt-dlp
     tqdm
     beautifulsoup4
     requests

spotdl/download/downloader.py

@@ -5,7 +5,7 @@
 import concurrent.futures
 
 from pathlib import Path
-from youtube_dl import YoutubeDL
+from yt_dlp import YoutubeDL
 from typing import List, Optional
 
 from spotdl.search import SongObject

spotdl/providers/provider_utils.py

@@ -126,7 +126,7 @@ def _get_smaller_file_path(input_song, output_format: str) -> Path:
 
     try:
         return Path(f"{smaller_name}.{output_format}").resolve()
-    except (OSError, WindowsError):
+    except OSError:
         # Expected to happen in the rare case when the saved path is too long,
         # even with the short filename
         raise OSError("Cannot save song due to path issues.")
@@ -166,7 +166,7 @@ def _get_converted_file_path(song_obj, output_format: str = None) -> Path:
         if len(str(converted_file_path.resolve().name)) > 256:
             print("Path was too long. Using Small Path.")
             return _get_smaller_file_path(song_obj, output_format)
-    except (OSError, WindowsError):
+    except OSError:
         return _get_smaller_file_path(song_obj, output_format)
 
     return converted_file_path

tests/cassettes/test_download_a_playlist.yaml

@@ -7,7 +7,7 @@ interactions:
       Accept-Encoding:
       - gzip, deflate
       Authorization:
-      - Bearer BQBbSe1hJOnpkb4G2InTMhA2mE7A3uZ05jxOiHTHKUNJlqUPy0mFp-z7-01Xe0NC_Ldg7uZrycpwAafON5c
+      - Bearer BQAZWdfkrJFAjE_JkZzWo0qEVvfs8s1lJyQ5JfACHhyqE8TcFYily0YtM1ssFOWV_So9JTEDgcP7vzoVkLw
       Connection:
       - keep-alive
       Content-Type:
@@ -48,7 +48,7 @@ interactions:
       content-type:
       - application/json; charset=utf-8
       date:
-      - Mon, 26 Jul 2021 23:10:26 GMT
+      - Tue, 24 Aug 2021 22:59:17 GMT
       server:
       - envoy
       strict-transport-security: