Guard against attempt to spawn process in UNKNOWN state

Author: mnaberez

supervisor/rpcinterface.py

@@ -299,6 +299,10 @@ def startProcess(self, name, wait=True):
         if process.get_state() in RUNNING_STATES:
             raise RPCError(Faults.ALREADY_STARTED, name)
 
+        if process.get_state() == ProcessStates.UNKNOWN:
+            raise RPCError(Faults.FAILED,
+                           "%s is in an unknown process state" % name)
+
         process.spawn()
 
         # We call reap() in order to more quickly obtain the side effects of

supervisor/tests/test_rpcinterfaces.py

@@ -311,7 +311,6 @@ def test_removeProcessGroup_still_running(self):
         self._assertRPCError(xmlrpc.Faults.STILL_RUNNING,
                              interface.removeProcessGroup, 'group1')
 
-
     def test_startProcess_already_started(self):
         from supervisor import xmlrpc
         options = DummyOptions()
@@ -324,6 +323,22 @@ def test_startProcess_already_started(self):
             interface.startProcess, 'foo'
             )
 
+    def test_startProcess_unknown_state(self):
+        from supervisor import xmlrpc
+        from supervisor.states import ProcessStates
+        options = DummyOptions()
+        pconfig = DummyPConfig(options, 'foo', __file__, autostart=False)
+        supervisord = PopulatedDummySupervisor(options, 'foo', pconfig)
+        supervisord.set_procattr('foo', 'pid', 10)
+        supervisord.set_procattr('foo', 'state', ProcessStates.UNKNOWN)
+        interface = self._makeOne(supervisord)
+        self._assertRPCError(
+            xmlrpc.Faults.FAILED,
+            interface.startProcess, 'foo'
+            )
+        process = supervisord.process_groups['foo'].processes['foo']
+        self.assertEqual(process.spawned, False)
+
     def test_startProcess_bad_group_name(self):
         options = DummyOptions()
         pconfig = DummyPConfig(options, 'foo', __file__, autostart=False)