Updates for proxy_env variable (for offline installation)

* 'environment' parameter cannot be properly omitted with 'omit' variable
ansible/ansible#46533
ansible/ansible#14130

"Default (omit)" is replaced by "default ({})" for proxy_env.

This is necessary to avoid a warning:
[WARNING]: could not parse environment value, skipping: [u '{{proxy_env | default (omit)}} ']

* The proxy_env variable has been moved to the beginning of the /vars/main.yml file.

* A small update to README.md file with an example of using proxy_env.

Author: vitabaks

README.md

@@ -108,14 +108,22 @@ Ansible ([What is Ansible](https://www.ansible.com/resources/videos/quick-start-
 
 4. Edit the variable file vars/[main.yml](./vars/main.yml)
 
+`vim vars/main.yml`
+
 ###### Minimum set of variables: 
+- `proxy_env` (for offline installation)
+
+example:
+```
+proxy_env:
+  http_proxy: http://proxy_server_ip:port
+  https_proxy: http://proxy_server_ip:port
+```
 - `cluster_vip`
 - `patroni_cluster_name`
 - `with_haproxy_load_balancing` `'true'` (Type A) or `'false'`/default (Type B)
 - `postgresql_version`
-- `proxy_env` (if required)
 
-`vim vars/main.yml`
 
 5. Run playbook:
 

tasks/add-repository.yml

@@ -14,7 +14,7 @@
         state: present
         update_cache: yes
       loop: "{{ apt_repository }}"
-  environment: "{{ proxy_env | default(omit) }}"
+  environment: '{{ proxy_env | default({}) }}'
   when: ansible_os_family == "Debian"
   tags: add_repo
 
@@ -62,6 +62,6 @@
         state: present
       when: install_postgresql_repo == "true"
       tags: install_postgresql_repo
-  environment: "{{ proxy_env | default(omit) }}"
+  environment: '{{ proxy_env | default({}) }}'
   when: ansible_os_family == "RedHat"
   tags: add_repo

tasks/confd.yml

@@ -7,7 +7,7 @@
     mode: u+x,g+x,o+x
     timeout: 30
     validate_certs: no
-  environment: "{{ proxy_env | default(omit) }}"
+  environment: '{{ proxy_env | default({}) }}'
   tags: [ get_confd, confd ]
 
 - name: confd | create conf directories

tasks/etcd.yml

@@ -6,7 +6,7 @@
     dest: /tmp/
     remote_src: yes
     validate_certs: no
-  environment: "{{ proxy_env | default(omit) }}"
+  environment: '{{ proxy_env | default({}) }}'
 
 - name: etcd cluster | copy "etcd" and "etcdctl" binary files to /usr/local/bin/
   copy:

tasks/haproxy.yml

@@ -55,7 +55,7 @@
         - openssl-libs
         - systemd-devel
       when: ansible_os_family == "RedHat"
-  environment: "{{ proxy_env | default(omit) }}"
+  environment: '{{ proxy_env | default({}) }}'
 
 - name: haproxy | add haproxy group
   group:

tasks/keepalived.yml

@@ -3,7 +3,7 @@
 - name: keepalived | install packages
   package:
     name: keepalived
-  environment: "{{ proxy_env | default(omit) }}"
+  environment: '{{ proxy_env | default({}) }}'
   tags: [ keepalived_install, keepalived ]
 
 - name: keepalived | make sure the kernel parameters "net.ipv4.ip_nonlocal_bind", "net.ipv4.ip_forward" are enabled

tasks/ntp.yml

@@ -3,7 +3,7 @@
 - name: ntp | install package
   package:
     name: ntp
-  environment: "{{ proxy_env | default(omit) }}"
+  environment: '{{ proxy_env | default({}) }}'
   tags: [ ntp_install, ntp ]
 
 - name: ntp | copy the ntp.conf template file

tasks/packages.yml

@@ -5,7 +5,7 @@
   package:
     name: "{{ item }}"
   loop: "{{ system_packages }}"
-  environment: "{{ proxy_env | default(omit) }}"
+  environment: '{{ proxy_env | default({}) }}'
   tags: install_packages
 
 # PostgreSQL prepare for install (for Debian based only)
@@ -14,7 +14,7 @@
       package:
         name: postgresql-common
         state: present
-      environment: "{{ proxy_env | default(omit) }}"
+      environment: '{{ proxy_env | default({}) }}'
 
     - name: disable initializing of a default postgresql cluster
       replace:
@@ -34,6 +34,6 @@
   package:
     name: "{{ item }}"
   loop: "{{ postgresql_packages }}"
-  environment: "{{ proxy_env | default(omit) }}"
+  environment: '{{ proxy_env | default({}) }}'
   when: postgresql_exists != "true"
   tags: install_postgres

tasks/patroni.yml

@@ -48,7 +48,7 @@
         name: urllib3<1.25
         executable: /usr/local/bin/pip3
         extra_args: "--trusted-host=pypi.python.org --trusted-host=pypi.org --trusted-host=files.pythonhosted.org"
-  environment: "{{ proxy_env | default(omit) }}"
+  environment: '{{ proxy_env | default({}) }}'
   tags: [ patroni, patroni_install ]
 
 - name: Patroni | create conf directory

tasks/pgbouncer.yml

@@ -3,7 +3,7 @@
 - name: PgBouncer | install package
   package:
     name: pgbouncer
-  environment: "{{ proxy_env | default(omit) }}"
+  environment: '{{ proxy_env | default({}) }}'
   tags: [ pgbouncer_install, pgbouncer ]
 
 - name: PgBouncer | ensure config directory "{{ pgbouncer_conf_dir }}" exist

tasks/pip.yml

@@ -15,5 +15,5 @@
       command: python3 get-pip.py --trusted-host=pypi.python.org --trusted-host=pypi.org --trusted-host=files.pythonhosted.org
       args:
         chdir: /tmp/
-  environment: "{{ proxy_env | default(omit) }}"
+  environment: '{{ proxy_env | default({}) }}'
   tags: [ pip_install, pip ]

vars/main.yml

@@ -1,4 +1,10 @@
 ---
+# Proxy variables (for offline installation)
+proxy_env: {}
+#  http_proxy: http://10.128.64.9:3128
+#  https_proxy: http://10.128.64.9:3128
+
+# -------------------------------------------
 
 # Cluster variables
 cluster_vip: "10.128.64.145" # for client access to databases in the cluster
@@ -158,10 +164,6 @@ pgbouncer_users:
 
 
 # System variables
-proxy_env: []
-#  http_proxy: http://10.128.64.9:3128
-#  https_proxy: http://10.128.64.9:3128
-
 ntp_enabled: 'false' # specify 'true' if you want to install and configure the ntp service
 ntp_servers: []
 #  - "10.128.64.44"