Cleanup: DataFlowAnalyzer, ignore MethodMayBeStatic for SmartCastManager

Author: mglukhikh

compiler/frontend/src/org/jetbrains/kotlin/resolve/calls/smartcasts/SmartCastManager.java

@@ -43,6 +43,8 @@
 import static org.jetbrains.kotlin.resolve.BindingContext.IMPLICIT_RECEIVER_SMARTCAST;
 import static org.jetbrains.kotlin.resolve.BindingContext.SMARTCAST;
 
+// We do not want to make methods static to keep SmartCastManager as a component
+@SuppressWarnings("MethodMayBeStatic")
 public class SmartCastManager {
 
     @NotNull

compiler/frontend/src/org/jetbrains/kotlin/types/expressions/DataFlowAnalyzer.java

@@ -245,7 +245,7 @@ public KotlinType checkType(
     }
 
     @Nullable
-    public SmartCastResult checkPossibleCast(
+    public static SmartCastResult checkPossibleCast(
             @NotNull KotlinType expressionType,
             @NotNull KtExpression expression,
             @NotNull ResolutionContext c
@@ -272,15 +272,15 @@ public KotlinType checkStatementType(@NotNull KtExpression expression, @NotNull
     }
 
     @NotNull
-    public KotlinTypeInfo illegalStatementType(@NotNull KtExpression expression, @NotNull ExpressionTypingContext context, @NotNull ExpressionTypingInternals facade) {
+    public static KotlinTypeInfo illegalStatementType(@NotNull KtExpression expression, @NotNull ExpressionTypingContext context, @NotNull ExpressionTypingInternals facade) {
         facade.checkStatementType(
                 expression, context.replaceExpectedType(TypeUtils.NO_EXPECTED_TYPE).replaceContextDependency(INDEPENDENT));
         context.trace.report(EXPRESSION_EXPECTED.on(expression, expression));
         return TypeInfoFactoryKt.noTypeInfo(context);
     }
 
     @NotNull
-    public Collection<KotlinType> getAllPossibleTypes(
+    public static Collection<KotlinType> getAllPossibleTypes(
             @NotNull KtExpression expression,
             @NotNull DataFlowInfo dataFlowInfo,
             @NotNull KotlinType type,