Add method visibility to Clover report

Author: Maks3w

src/CodeCoverage/Report/Clover.php

@@ -84,10 +84,11 @@ public function process(PHP_CodeCoverage $coverage, $target = null, $name = null
                     }
 
                     $lines[$method['startLine']] = [
-                        'count' => $methodCount,
-                        'crap'  => $method['crap'],
-                        'type'  => 'method',
-                        'name'  => $methodName
+                        'count'       => $methodCount,
+                        'crap'        => $method['crap'],
+                        'type'        => 'method',
+                        'visibility'  => $method['visibility'],
+                        'name'        => $methodName
                     ];
                 }
 
@@ -175,6 +176,10 @@ public function process(PHP_CodeCoverage $coverage, $target = null, $name = null
                     $xmlLine->setAttribute('name', $data['name']);
                 }
 
+                if (isset($data['visibility'])) {
+                    $xmlLine->setAttribute('visibility', $data['visibility']);
+                }
+
                 if (isset($data['crap'])) {
                     $xmlLine->setAttribute('crap', $data['crap']);
                 }

src/CodeCoverage/Report/Node/File.php

@@ -657,24 +657,25 @@ protected function crap($ccn, $coverage)
 
     /**
      * @param string $methodName
-     * @param array $method
+     * @param array  $method
      * @param string $link
      *
      * @return array
      */
     private function newMethod($methodName, array $method, $link)
     {
         return [
-            'methodName' => $methodName,
-            'signature' => $method['signature'],
-            'startLine' => $method['startLine'],
-            'endLine' => $method['endLine'],
+            'methodName'      => $methodName,
+            'visibility'      => $method['visibility'],
+            'signature'       => $method['signature'],
+            'startLine'       => $method['startLine'],
+            'endLine'         => $method['endLine'],
             'executableLines' => 0,
-            'executedLines' => 0,
-            'ccn' => $method['ccn'],
-            'coverage' => 0,
-            'crap' => 0,
-            'link' => $link . $method['startLine']
+            'executedLines'   => 0,
+            'ccn'             => $method['ccn'],
+            'coverage'        => 0,
+            'crap'            => 0,
+            'link'            => $link . $method['startLine'],
         ];
     }
 }

tests/PHP/CodeCoverage/Report/FactoryTest.php

@@ -61,7 +61,8 @@ public function testSomething()
                             'coverage'        => 100,
                             'crap'            => '1',
                             'link'            => 'BankAccount.php.html#6',
-                            'methodName'      => 'getBalance'
+                            'methodName'      => 'getBalance',
+                            'visibility'      => 'public',
                         ],
                         'setBalance' => [
                             'signature'       => 'setBalance($balance)',
@@ -73,7 +74,8 @@ public function testSomething()
                             'coverage'        => 0,
                             'crap'            => 6,
                             'link'            => 'BankAccount.php.html#11',
-                            'methodName'      => 'setBalance'
+                            'methodName'      => 'setBalance',
+                            'visibility'      => 'protected',
                         ],
                         'depositMoney' => [
                             'signature'       => 'depositMoney($balance)',
@@ -85,7 +87,8 @@ public function testSomething()
                             'coverage'        => 100,
                             'crap'            => '1',
                             'link'            => 'BankAccount.php.html#20',
-                            'methodName'      => 'depositMoney'
+                            'methodName'      => 'depositMoney',
+                            'visibility'      => 'public',
                         ],
                         'withdrawMoney' => [
                             'signature'       => 'withdrawMoney($balance)',
@@ -97,7 +100,8 @@ public function testSomething()
                             'coverage'        => 100,
                             'crap'            => '1',
                             'link'            => 'BankAccount.php.html#27',
-                            'methodName'      => 'withdrawMoney'
+                            'methodName'      => 'withdrawMoney',
+                            'visibility'      => 'public',
                         ],
                     ],
                     'startLine'       => 2,

tests/_files/BankAccount-clover.xml

@@ -5,18 +5,18 @@
       <class name="BankAccount" namespace="global">
         <metrics methods="4" coveredmethods="3" conditionals="0" coveredconditionals="0" statements="10" coveredstatements="5" elements="14" coveredelements="8"/>
       </class>
-      <line num="6" type="method" name="getBalance" crap="1" count="2"/>
+      <line num="6" type="method" name="getBalance" visibility="public" crap="1" count="2"/>
       <line num="8" type="stmt" count="2"/>
-      <line num="11" type="method" name="setBalance" crap="6" count="0"/>
+      <line num="11" type="method" name="setBalance" visibility="protected" crap="6" count="0"/>
       <line num="13" type="stmt" count="0"/>
       <line num="14" type="stmt" count="0"/>
       <line num="15" type="stmt" count="0"/>
       <line num="16" type="stmt" count="0"/>
       <line num="18" type="stmt" count="0"/>
-      <line num="20" type="method" name="depositMoney" crap="1" count="2"/>
+      <line num="20" type="method" name="depositMoney" visibility="public" crap="1" count="2"/>
       <line num="22" type="stmt" count="2"/>
       <line num="24" type="stmt" count="1"/>
-      <line num="27" type="method" name="withdrawMoney" crap="1" count="2"/>
+      <line num="27" type="method" name="withdrawMoney" visibility="public" crap="1" count="2"/>
       <line num="29" type="stmt" count="2"/>
       <line num="31" type="stmt" count="1"/>
       <metrics loc="33" ncloc="33" classes="1" methods="4" coveredmethods="3" conditionals="0" coveredconditionals="0" statements="10" coveredstatements="5" elements="14" coveredelements="8"/>

tests/_files/class-with-anonymous-function-clover.xml

@@ -5,7 +5,7 @@
       <class name="CoveredClassWithAnonymousFunctionInStaticMethod" namespace="global">
         <metrics methods="2" coveredmethods="1" conditionals="0" coveredconditionals="0" statements="5" coveredstatements="4" elements="7" coveredelements="5"/>
       </class>
-      <line num="5" type="method" name="runAnonymous" crap="1.04" count="1"/>
+      <line num="5" type="method" name="runAnonymous" visibility="public" crap="1.04" count="1"/>
       <line num="7" type="stmt" count="1"/>
       <line num="9" type="stmt" count="1"/>
       <line num="10" type="stmt" count="0"/>