Skip to content

Commit 8536df1

Browse files
committed
chore(build): fail experimental Dart build but allow Travis failures
1 parent a94f051 commit 8536df1

File tree

2 files changed

+4
-12
lines changed

2 files changed

+4
-12
lines changed

.travis.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ env:
4242
matrix:
4343
allow_failures:
4444
- env: "MODE=saucelabs DART_CHANNEL=dev"
45+
- env: "MODE=dart_experimental DART_CHANNEL=dev"
4546

4647
addons:
4748
firefox: "38.0"

tools/build/dartanalyzer.js

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -107,19 +107,10 @@ module.exports = function(gulp, plugins, config) {
107107
if (report.length > 0) {
108108
error = 'Dartanalyzer showed ' + report.join(', ');
109109
}
110-
if (useDdc) {
111-
// TODO(yjbanov): fail the build when:
112-
// - DDC analyzer is stable enough
113-
// - We have cleaned up all DDC warnings
114-
console.log(error);
115-
done();
116-
} else {
117-
done(error);
118-
}
110+
done(error);
119111
});
120-
stream.on('error', function(e) {
121-
// TODO(yjbanov): fail the build when DDC is stable enough
122-
console.log('ERROR: failed to run DDC at all: ' + e);
112+
stream.on('error', function(error) {
113+
done(error);
123114
});
124115
}
125116
};

0 commit comments

Comments
 (0)