Skip to content

Commit c2279dd

Browse files
committed
fix(build): make e2e tests faster
Closes angular#3822
1 parent 9cc1cd2 commit c2279dd

File tree

3 files changed

+3
-2
lines changed

3 files changed

+3
-2
lines changed

modules/benchmarks/src/naive_infinite_scroll/index.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
<button id="run-btn">Run</button>
1414
<button id="reset-btn">Reset</button>
1515
</div>
16-
<scroll-app></scroll-app>
16+
<scroll-app>Loading...</scroll-app>
1717

1818
$SCRIPTS$
1919
</body>

modules/examples/e2e_test/message_broker/message_broker_spec.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ describe('message bus', function() {
99

1010
it('should receive a response from the worker', function() {
1111
browser.get(URL);
12+
browser.sleep(5000);
1213

1314
var VALUE = "hi there";
1415
var input = element.all(by.css("#echo_input")).first();

protractor-shared.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,7 @@ function patchProtractorWait(browser) {
192192
var sleepInterval = process.env.TRAVIS || process.env.JENKINS_URL ? 14000 : 8000;
193193
browser.get = function() {
194194
var result = _get.apply(this, arguments);
195-
browser.sleep(sleepInterval);
195+
browser.driver.wait(protractor.until.elementLocated(By.js('var cs = document.body.children; var isLoading = false; for (var i = 0; i < cs.length; i++) {if (cs[i].textContent.indexOf("Loading...") > -1) isLoading = true; } return !isLoading ? document.body.children : null')), sleepInterval);
196196
return result;
197197
}
198198
}

0 commit comments

Comments
 (0)