Bug#34338950 Fix xapi crash when disconnect

If mysqlx_session_close is called after a disconnect, xapi would crash.

Change-Id: I301fc4f16b0cb43bf27b0e679e744480c3ebb6ec

Author: silvakid

common/session.cc

@@ -708,7 +708,10 @@ Pooled_session::Pooled_session(cdk::ds::Multi_source &ds)
 
 Pooled_session::~Pooled_session()
 {
-  release();
+  //Let's catch any errors when releasing the session
+  try {
+    release();
+  } catch (...) {}
 }
 
 void Pooled_session::release()

xapi/tests/xapi-t.cc

@@ -3608,3 +3608,40 @@ TEST_F(xapi, normalize_ssl_options)
   }
 
 }
+
+TEST_F(xapi, bug34338950)
+{
+  SKIP_IF_NO_XPLUGIN;
+  AUTHENTICATE();
+
+  mysqlx_error_t *error;
+  mysqlx_session_t *sess;
+
+  sess = mysqlx_get_session_from_url(get_uri().c_str(), &error);
+
+  if (sess == NULL) {
+    std::stringstream str;
+    str << "Unexpected error: " << mysqlx_error_message(error) << endl;
+    mysqlx_free(error);
+    FAIL() << str.str();
+  }
+
+  mysqlx_result_t *res = exec_sql(sess, "SELECT CONNECTION_ID() as _pid");
+
+  if (!res) throw "Failed to query CONNECTION_ID() ";
+
+  mysqlx_row_t *row = mysqlx_row_fetch_one(res);
+
+  if (!row) throw "Failed to get value of CONNECTION_ID()";
+
+  uint64_t pid;
+  if (RESULT_OK != mysqlx_get_uint(row, 0, &pid))
+    throw "Failed to get value of CONNECTION_ID()";
+
+  std::string kill_connection = "KILL ";
+  kill_connection += std::to_string(pid);
+
+  exec_sql(kill_connection.c_str());
+
+  mysqlx_session_close(sess);
+}