Skip to content

Commit d42c420

Browse files
committed
fixed spider custom_settings
scrapy#1128 moved spidercls.update_settings call to a later stage; this commit moves it back.
1 parent cc2f3e1 commit d42c420

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

scrapy/crawler.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ def __init__(self, spidercls, settings):
2929

3030
self.spidercls = spidercls
3131
self.settings = settings.copy()
32+
self.spidercls.update_settings(self.settings)
3233

3334
self.signals = SignalManager(self)
3435
self.stats = load_object(self.settings['STATS_CLASS'])(self)
@@ -44,9 +45,7 @@ def __init__(self, spidercls, settings):
4445
self.logformatter = lf_cls.from_crawler(self)
4546
self.extensions = ExtensionManager.from_crawler(self)
4647

47-
self.spidercls.update_settings(self.settings)
4848
self.settings.freeze()
49-
5049
self.crawling = False
5150
self.spider = None
5251
self.engine = None

0 commit comments

Comments
 (0)