Skip to content

Commit 3a1d519

Browse files
committed
deprecation warning, changelog entry
1 parent 5bcd119 commit 3a1d519

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

actionpack/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
## Rails 3.2.0 (unreleased) ##
22

3+
* Refactor ActionDispatch::ShowExceptions. Controller is responsible for choice to show exceptions. *Sergey Nartimov*
4+
5+
It's possible to override +show_detailed_exceptions?+ in controllers to specify which requests should provide debugging information on errors.
6+
37
* Responders now return 204 No Content for API requests without a response body (as in the new scaffold) *José Valim*
48

59
* Added ActionDispatch::RequestId middleware that'll make a unique X-Request-Id header available to the response and enables the ActionDispatch::Request#uuid method. This makes it easy to trace requests from end-to-end in the stack and to identify individual requests in mixed logs like Syslog *DHH*

actionpack/lib/action_dispatch/middleware/show_exceptions.rb

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
require 'action_controller/metal/exceptions'
33
require 'active_support/notifications'
44
require 'action_dispatch/http/request'
5+
require 'active_support/deprecation'
56

67
module ActionDispatch
78
# This middleware rescues any exception returned by the application and renders
@@ -38,7 +39,8 @@ class ShowExceptions
3839
"application's log file and/or the web server's log file to find out what " <<
3940
"went wrong.</body></html>"]]
4041

41-
def initialize(app)
42+
def initialize(app, consider_all_requests_local = nil)
43+
ActiveSupport::Deprecation.warn "Passing consider_all_requests_local option to ActionDispatch::ShowExceptions middleware no longer works" unless consider_all_requests_local.nil?
4244
@app = app
4345
end
4446

0 commit comments

Comments
 (0)