Speed improvements when using xdebug

- Init data by running xdebug with 'unused' and 'dead code' flags on all whitelist files
- Run xdebug without flags for each test method
- Cache num lines check for each file, to prevent superflous checks
- (SB) Fix CS/WS issues

Author: Rob Caiger

src/CodeCoverage.php

@@ -113,6 +113,20 @@ class CodeCoverage
      */
     private $unintentionallyCoveredSubclassesWhitelist = [];
 
+    /**
+     * Determine if the data has been initialized or not
+     *
+     * @var bool
+     */
+    private $isInitialized = false;
+
+    /**
+     * Determine whether we need to check for dead and unused code on each test
+     *
+     * @var bool
+     */
+    private $shouldCheckForDeadAndUnused = true;
+
     /**
      * Constructor.
      *
@@ -154,6 +168,7 @@ public function getReport()
      */
     public function clear()
     {
+        $this->isInitialized = false;
         $this->currentId = null;
         $this->data      = [];
         $this->tests     = [];
@@ -237,9 +252,13 @@ public function start($id, $clear = false)
             $this->clear();
         }
 
+        if ($this->isInitialized === false) {
+            $this->initializeData();
+        }
+
         $this->currentId = $id;
 
-        $this->driver->start();
+        $this->driver->start($this->shouldCheckForDeadAndUnused);
     }
 
     /**
@@ -687,13 +706,7 @@ private function addUncoveredFilesFromWhitelist()
                 continue;
             }
 
-            if ($this->processUncoveredFilesFromWhitelist) {
-                $this->processUncoveredFileFromWhitelist(
-                    $uncoveredFile,
-                    $data,
-                    $uncoveredFiles
-                );
-            } else {
+            if (!$this->processUncoveredFilesFromWhitelist) {
                 $data[$uncoveredFile] = [];
 
                 $lines = count(file($uncoveredFile));
@@ -707,31 +720,6 @@ private function addUncoveredFilesFromWhitelist()
         $this->append($data, 'UNCOVERED_FILES_FROM_WHITELIST');
     }
 
-    /**
-     * @param string $uncoveredFile
-     * @param array  $data
-     * @param array  $uncoveredFiles
-     */
-    private function processUncoveredFileFromWhitelist($uncoveredFile, array &$data, array $uncoveredFiles)
-    {
-        $this->driver->start();
-        include_once $uncoveredFile;
-        $coverage = $this->driver->stop();
-
-        foreach ($coverage as $file => $fileCoverage) {
-            if (!isset($data[$file]) &&
-                in_array($file, $uncoveredFiles)) {
-                foreach (array_keys($fileCoverage) as $key) {
-                    if ($fileCoverage[$key] == Driver::LINE_EXECUTED) {
-                        $fileCoverage[$key] = Driver::LINE_NOT_EXECUTED;
-                    }
-                }
-
-                $data[$file] = $fileCoverage;
-            }
-        }
-    }
-
     /**
      * Returns the lines of a source file that should be ignored.
      *
@@ -1074,4 +1062,45 @@ private function processUnintentionallyCoveredUnits(array $unintentionallyCovere
 
         return array_values($unintentionallyCoveredUnits);
     }
+
+    /**
+     * If we are processing uncovered files from whitelist,
+     * we can initialize the data before we start to speed up the tests
+     */
+    protected function initializeData()
+    {
+        $this->isInitialized = true;
+
+        if ($this->processUncoveredFilesFromWhitelist) {
+
+            $this->shouldCheckForDeadAndUnused = false;
+
+            $this->driver->start(true);
+
+            foreach ($this->filter->getWhitelist() as $file) {
+                if ($this->filter->isFile($file)) {
+                    include_once($file);
+                }
+            }
+
+            $data = [];
+            $coverage = $this->driver->stop();
+
+            foreach ($coverage as $file => $fileCoverage) {
+                if ($this->filter->isFiltered($file)) {
+                    continue;
+                }
+
+                foreach (array_keys($fileCoverage) as $key) {
+                    if ($fileCoverage[$key] == PHP_CodeCoverage_Driver::LINE_EXECUTED) {
+                        $fileCoverage[$key] = PHP_CodeCoverage_Driver::LINE_NOT_EXECUTED;
+                    }
+                }
+
+                $data[$file] = $fileCoverage;
+            }
+
+            $this->append($coverage, 'UNCOVERED_FILES_FROM_WHITELIST');
+        }
+    }
 }

src/Driver/Driver.php

@@ -39,7 +39,7 @@ interface Driver
     /**
      * Start collection of code coverage information.
      */
-    public function start();
+    public function start($determineUnusedAndDead = true);
 
     /**
      * Stop collection of code coverage information.

src/Driver/HHVM.php

@@ -20,7 +20,7 @@ class HHVM extends Xdebug
     /**
      * Start collection of code coverage information.
      */
-    public function start()
+    public function start($determineUnusedAndDead = true)
     {
         xdebug_start_code_coverage();
     }

src/Driver/PHPDBG.php

@@ -40,7 +40,7 @@ public function __construct()
     /**
      * Start collection of code coverage information.
      */
-    public function start()
+    public function start($determineUnusedAndDead = true)
     {
         phpdbg_start_oplog();
     }

src/Driver/Xdebug.php

@@ -19,6 +19,13 @@
  */
 class Xdebug implements Driver
 {
+    /**
+     * Cache the number of lines for each file
+     *
+     * @var array
+     */
+    private $cacheNumLines = [];
+
     /**
      * Constructor.
      */
@@ -39,9 +46,13 @@ public function __construct()
     /**
      * Start collection of code coverage information.
      */
-    public function start()
+    public function start($determineUnusedAndDead = true)
     {
-        xdebug_start_code_coverage(XDEBUG_CC_UNUSED | XDEBUG_CC_DEAD_CODE);
+        if ($determineUnusedAndDead) {
+            xdebug_start_code_coverage(XDEBUG_CC_UNUSED | XDEBUG_CC_DEAD_CODE);
+        } else {
+            xdebug_start_code_coverage();
+        }
     }
 
     /**
@@ -88,13 +99,17 @@ private function cleanup(array $data)
      */
     private function getNumberOfLinesInFile($file)
     {
-        $buffer = file_get_contents($file);
-        $lines  = substr_count($buffer, "\n");
+        if (!isset($this->cacheNumLines[$file])) {
+            $buffer = file_get_contents($file);
+            $lines  = substr_count($buffer, "\n");
+
+            if (substr($buffer, -1) !== "\n") {
+                $lines++;
+            }
 
-        if (substr($buffer, -1) !== "\n") {
-            $lines++;
+            $this->cacheNumLines[$file] = $lines;
         }
 
-        return $lines;
+        return $this->cacheNumLines[$file];
     }
 }