Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: pakisha/golang-web-dev
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: GoesToEleven/golang-web-dev
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 13 commits
  • 7 files changed
  • 4 contributors

Commits on Nov 16, 2019

  1. fix numeric identifier in readme

    Dave Clement committed Nov 16, 2019
    Configuration menu
    Copy the full SHA
    c85a4b7 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2019

  1. update appengine deployment for v1.13

    @di-reu
    di-reu committed Nov 27, 2019
    Configuration menu
    Copy the full SHA
    479d7e0 View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2019

  1. make localhost:8080/dog/ work

    @MarkRosemaker
    MarkRosemaker authored Dec 12, 2019
    Configuration menu
    Copy the full SHA
    388c20d View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2019

  1. make new version work 

    I've spend some time trying to figure out why it didn't work for me. The reason is that Google updated the system.

Google's changes:
- use main() instead of init()
- specify go version in app.yaml
- most other declarations in app.yaml now invalid
- pass project name and version as flags in the gcloud command
- python install not needed anymore

Plus, you need ListenAndServe of course! ;)

I can confirm that it now works with the changes I made to the files.
    @MarkRosemaker
    MarkRosemaker authored Dec 13, 2019
    Configuration menu
    Copy the full SHA
    84dcfc2 View commit details
    Browse the repository at this point in the history

  2. make new version work 

    - Google now wants you to use main instead of init
- don't forget to ListenAndServe
    @MarkRosemaker
    MarkRosemaker authored Dec 13, 2019
    Configuration menu
    Copy the full SHA
    304c653 View commit details
    Browse the repository at this point in the history

  3. make new version work 

    - Google now wants you to use main instead of init
- don't forget to ListenAndServe
    @MarkRosemaker
    MarkRosemaker authored Dec 13, 2019
    Configuration menu
    Copy the full SHA
    f862b2b View commit details
    Browse the repository at this point in the history

  4. Merge pull request GoesToEleven#26 from davidclement/davidclement/fix… 

    …-numerid-identifier-in-readme

fix numeric identifier in readme
    @GoesToEleven
    GoesToEleven authored Dec 13, 2019
    Configuration menu
    Copy the full SHA
    a8019a4 View commit details
    Browse the repository at this point in the history

  5. Merge pull request GoesToEleven#27 from di-reu/update-appengine-deploy 

    update appengine deployment for v1.13
    @GoesToEleven
    GoesToEleven authored Dec 13, 2019
    Configuration menu
    Copy the full SHA
    774f612 View commit details
    Browse the repository at this point in the history

  6. Merge pull request GoesToEleven#29 from MarkRosemaker/patch-1 

    make localhost:8080/dog/ work
    @GoesToEleven
    GoesToEleven authored Dec 13, 2019
    Configuration menu
    Copy the full SHA
    75bf2c1 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' into patch-3

    @GoesToEleven
    GoesToEleven authored Dec 13, 2019
    Configuration menu
    Copy the full SHA
    21a5b12 View commit details
    Browse the repository at this point in the history

  8. Merge pull request GoesToEleven#30 from MarkRosemaker/patch-3 

    make new version work
    @GoesToEleven
    GoesToEleven authored Dec 13, 2019
    Configuration menu
    Copy the full SHA
    91a6179 View commit details
    Browse the repository at this point in the history

  9. Merge pull request GoesToEleven#33 from MarkRosemaker/patch-6 

    make new version work
    @GoesToEleven
    GoesToEleven authored Dec 13, 2019
    Configuration menu
    Copy the full SHA
    235c188 View commit details
    Browse the repository at this point in the history

  10. Merge pull request GoesToEleven#34 from MarkRosemaker/patch-7 

    make new version work
    @GoesToEleven
    GoesToEleven authored Dec 13, 2019
    Configuration menu
    Copy the full SHA
    ef2d6fb View commit details
    Browse the repository at this point in the history
Loading