From 76ed80a85731f6300fafb1f2f76f343da6f9731f Mon Sep 17 00:00:00 2001 From: Jennifer Davis Date: Thu, 6 Oct 2022 16:11:23 -0700 Subject: [PATCH 1/2] fix: codeowners to reflect standards I know php-samples-reviewers only has 2 people, but we should update the php-sample-reviewers so that it's synced correctly. php-admin are the repo owners. --- CODEOWNERS | 28 ++++++++++++++++++---------- 1 file changed, 18 insertions(+), 10 deletions(-) diff --git a/CODEOWNERS b/CODEOWNERS index 03cb1d661a..30aa730ec1 100644 --- a/CODEOWNERS +++ b/CODEOWNERS @@ -7,16 +7,24 @@ # The php-admins team is the default owner for anything not # explicitly taken by someone else. -* @GoogleCloudPlatform/php-admins - -/bigtable/**/*.php @GoogleCloudPlatform/cloud-native-db-dpes @GoogleCloudPlatform/php-admins -/cloud_sql/**/*.php @GoogleCloudPlatform/infra-db-dpes @GoogleCloudPlatform/php-admins -/datastore/**/*.php @GoogleCloudPlatform/cloud-native-db-dpes @GoogleCloudPlatform/php-admins -/firestore/**/*.php @GoogleCloudPlatform/cloud-native-db-dpes @GoogleCloudPlatform/php-admins -/iot/ @gcseh @GoogleCloudPlatform/api-iot @GoogleCloudPlatform/php-admins -/storage/ @GoogleCloudPlatform/storage-dpe @GoogleCloudPlatform/php-admins -/spanner/ @GoogleCloudPlatform/api-spanner @GoogleCloudPlatform/php-admins - +* @GoogleCloudPlatform/php-samples-reviewers + +# Kokoro +.kokoro @GoogleCloudPlatform/php-admins + +/bigtable/**/*.php @GoogleCloudPlatform/cloud-native-db-dpes @GoogleCloudPlatform/php-samples-reviewers +/cloud_sql/**/*.php @GoogleCloudPlatform/infra-db-dpes @GoogleCloudPlatform/php-samples-reviewers +/datastore/**/*.php @GoogleCloudPlatform/cloud-native-db-dpes @GoogleCloudPlatform/php-samples-reviewers +/firestore/**/*.php @GoogleCloudPlatform/cloud-native-db-dpes @GoogleCloudPlatform/php-samples-reviewers +/iot/ @gcseh @GoogleCloudPlatform/api-iot @GoogleCloudPlatform/php-samples-reviewers +/storage/ @GoogleCloudPlatform/storage-dpe @GoogleCloudPlatform/php-samples-reviewers +/spanner/ @GoogleCloudPlatform/api-spanner @GoogleCloudPlatform/php-samples-reviewers + +# Serverless, Orchestration, DevOps +/appengine/ @GoogleCloudPlatform/torus-dpe @GoogleCloudPlatform/php-samples-reviewers +/functions/ @GoogleCloudPlatform/torus-dpe @GoogleCloudPlatform/php-samples-reviewers +/run/ @GoogleCloudPlatform/torus-dpe @GoogleCloudPlatform/php-samples-reviewers +/eventarc/ @GoogleCloudPlatform/torus-dpe @GoogleCloudPlatform/php-samples-reviewers # Functions samples owned by the Firebase team /functions/firebase_analytics @schandel @samtstern From 49d8dd010998e5c730843aaefcadfa556970683d Mon Sep 17 00:00:00 2001 From: Jennifer Davis Date: Thu, 6 Oct 2022 16:23:54 -0700 Subject: [PATCH 2/2] Update CODEOWNERS making sure to use the right DPE group --- CODEOWNERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CODEOWNERS b/CODEOWNERS index 30aa730ec1..b167070236 100644 --- a/CODEOWNERS +++ b/CODEOWNERS @@ -17,7 +17,7 @@ /datastore/**/*.php @GoogleCloudPlatform/cloud-native-db-dpes @GoogleCloudPlatform/php-samples-reviewers /firestore/**/*.php @GoogleCloudPlatform/cloud-native-db-dpes @GoogleCloudPlatform/php-samples-reviewers /iot/ @gcseh @GoogleCloudPlatform/api-iot @GoogleCloudPlatform/php-samples-reviewers -/storage/ @GoogleCloudPlatform/storage-dpe @GoogleCloudPlatform/php-samples-reviewers +/storage/ @GoogleCloudPlatform/cloud-storage-dpe @GoogleCloudPlatform/php-samples-reviewers /spanner/ @GoogleCloudPlatform/api-spanner @GoogleCloudPlatform/php-samples-reviewers # Serverless, Orchestration, DevOps