Fix Android Lint issues. Moved ripple effect to foreground of views and updated navigation component.

Author: daniel-stoneuk

app/src/main/java/guide/graphql/toc/ui/sections/SectionsFragment.kt

@@ -19,7 +19,7 @@ class SectionsFragment : Fragment() {
     private val viewModel: SectionsViewModel by viewModels()
 
     private lateinit var binding: SectionsFragmentBinding
-    val args: SectionsFragmentArgs by navArgs()
+    private val args: SectionsFragmentArgs by navArgs()
 
     override fun onCreateView(
         inflater: LayoutInflater,

app/src/main/res/layout/chapter.xml

@@ -3,7 +3,7 @@
     xmlns:app="http://schemas.android.com/apk/res-auto"
     android:layout_width="match_parent"
     android:layout_height="wrap_content"
-    android:background="?selectableItemBackground"
+    android:foreground="?selectableItemBackground"
     android:paddingStart="20dp"
     android:paddingEnd="20dp"
     android:paddingTop="16dp"

app/src/main/res/layout/section.xml

@@ -3,7 +3,7 @@
     xmlns:app="http://schemas.android.com/apk/res-auto"
     android:layout_width="match_parent"
     android:layout_height="wrap_content"
-    android:background="?selectableItemBackground"
+    android:foreground="?selectableItemBackground"
     android:paddingStart="30dp"
     android:paddingTop="20dp"
     android:paddingEnd="30dp"

app/src/main/res/values/styles.xml

@@ -12,12 +12,12 @@
     </style>
 
     <style name="AppTheme.Heading">
-        <item name="android:textSize">18dp</item>
+        <item name="android:textSize">18sp</item>
         <item name="android:textStyle">bold</item>
     </style>
 
     <style name="AppTheme.Subheading">
-        <item name="android:textSize">18dp</item>
+        <item name="android:textSize">18sp</item>
     </style>
 
 </resources>

build.gradle.kts

@@ -6,7 +6,7 @@ buildscript {
 
     dependencies {
         classpath("com.android.tools.build:gradle:4.1.0-beta03")
-        classpath("androidx.navigation:navigation-safe-args-gradle-plugin:2.2.2")
+        classpath("androidx.navigation:navigation-safe-args-gradle-plugin:2.3.0")
         classpath("org.jetbrains.kotlin:kotlin-gradle-plugin:1.3.72")
     }
 }