Fix bug: calling mutation from unmounted component

lorensr · lorensr · commit 0a6aa9e831f5 · 2019-03-22T01:15:42.000-04:00
diff --git a/src/components/Section.js b/src/components/Section.js
@@ -33,7 +33,7 @@ class Section extends Component {
       return
     }
 
-    setTimeout(() => {
+    this.timeoutID = setTimeout(() => {
       this.props.viewedSection({
         variables: { id }
       })
@@ -53,6 +53,7 @@ class Section extends Component {
   }
 
   componentWillUnmount() {
+    clearTimeout(this.timeoutID)
     window.removeEventListener('scroll', this.handleScroll)
   }
 

Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,7 @@ class Section extends Component {`
`33`	`33`	`return`
`34`	`34`	`}`
`35`	`35`
`36`		`- setTimeout(() => {`
	`36`	`+ this.timeoutID = setTimeout(() => {`
`37`	`37`	`this.props.viewedSection({`
`38`	`38`	`variables: { id }`
`39`	`39`	`})`
`@@ -53,6 +53,7 @@ class Section extends Component {`
`53`	`53`	`}`
`54`	`54`
`55`	`55`	`componentWillUnmount() {`
	`56`	`+ clearTimeout(this.timeoutID)`
`56`	`57`	`window.removeEventListener('scroll', this.handleScroll)`
`57`	`58`	`}`
`58`	`59`