Fix bug: calling mutation from unmounted component

lorensr · lorensr · commit ac2ca8199cef · 2019-03-22T01:15:41.000-04:00
diff --git a/src/components/Section.js b/src/components/Section.js
@@ -31,7 +31,7 @@ class Section extends Component {
       return
     }
 
-    setTimeout(() => {
+    this.timeoutID = setTimeout(() => {
       this.props.viewedSection({
         variables: { id }
       })
@@ -51,6 +51,7 @@ class Section extends Component {
   }
 
   componentWillUnmount() {
+    clearTimeout(this.timeoutID)
     window.removeEventListener('scroll', this.handleScroll)
   }
 

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ class Section extends Component {`
`31`	`31`	`return`
`32`	`32`	`}`
`33`	`33`
`34`		`- setTimeout(() => {`
	`34`	`+ this.timeoutID = setTimeout(() => {`
`35`	`35`	`this.props.viewedSection({`
`36`	`36`	`variables: { id }`
`37`	`37`	`})`
`@@ -51,6 +51,7 @@ class Section extends Component {`
`51`	`51`	`}`
`52`	`52`
`53`	`53`	`componentWillUnmount() {`
	`54`	`+ clearTimeout(this.timeoutID)`
`54`	`55`	`window.removeEventListener('scroll', this.handleScroll)`
`55`	`56`	`}`
`56`	`57`