Fix bug: calling mutation from unmounted component

lorensr · lorensr · commit bca3f28ade81 · 2019-03-22T01:13:35.000-04:00
diff --git a/src/components/Section.js b/src/components/Section.js
@@ -14,7 +14,7 @@ class Section extends Component {
       return
     }
 
-    setTimeout(() => {
+    this.timeoutID = setTimeout(() => {
       this.props.viewedSection({
         variables: { id }
       })
@@ -27,6 +27,10 @@ class Section extends Component {
     }
   }
 
+  componentWillUnmount() {
+    clearTimeout(this.timeoutID)
+  }
+
   componentDidUpdate(prevProps) {
     const { id } = this.props.section
     const sectionChanged = get(prevProps, 'section.id') !== id

Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@ class Section extends Component {`
`14`	`14`	`return`
`15`	`15`	`}`
`16`	`16`
`17`		`- setTimeout(() => {`
	`17`	`+ this.timeoutID = setTimeout(() => {`
`18`	`18`	`this.props.viewedSection({`
`19`	`19`	`variables: { id }`
`20`	`20`	`})`
`@@ -27,6 +27,10 @@ class Section extends Component {`
`27`	`27`	`}`
`28`	`28`	`}`
`29`	`29`
	`30`	`+ componentWillUnmount() {`
	`31`	`+ clearTimeout(this.timeoutID)`
	`32`	`+ }`
	`33`	`+`
`30`	`34`	`componentDidUpdate(prevProps) {`
`31`	`35`	`const { id } = this.props.section`
`32`	`36`	`const sectionChanged = get(prevProps, 'section.id') !== id`